Commit ae44e5f
test: add tests for missing https agent options
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.
Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js
PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 796007b commit ae44e5f
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,6 +34,8 @@ const updatedValues = new Map([ | |||
| 34 | 34 | ['dhparam', fixtures.readKey('dh2048.pem')], | |
| 35 | 35 | ['ecdhCurve', 'secp384r1'], | |
| 36 | 36 | ['honorCipherOrder', true], | |
| 37 | + ['minVersion', 'TLSv1.1'], | ||
| 38 | + ['maxVersion', 'TLSv1.3'], | ||
| 37 | 39 | ['secureOptions', crypto.constants.SSL_OP_CIPHER_SERVER_PREFERENCE], | |
| 38 | 40 | ['secureProtocol', 'TLSv1_1_method'], | |
| 39 | 41 | ['sessionIdContext', 'sessionIdContext'], | |
0 commit comments