test,doc: fix https agent minVersion/maxVersion test and docs - #38202
Closed
Trott wants to merge 3 commits into
Closed
test,doc: fix https agent minVersion/maxVersion test and docs#38202Trott wants to merge 3 commits into
Trott wants to merge 3 commits into
Conversation
`value` was always being assigned to an `undefined` property of an Array. Thus, the assertions that depended on `value` being defined were never being checked. Assign `value` the correct...er...value.
This comment has been minimized.
benjamingr
approved these changes
Apr 11, 2021
jasnell
approved these changes
Apr 11, 2021
This comment has been minimized.
lpinca
approved these changes
Apr 11, 2021
Copy link
Copy Markdown
Member
|
"shoudl" typo in second commit message. |
Sorry, something went wrong.
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js
Minor changes mostly to improve compliance with our style guide.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marsonya
approved these changes
Apr 13, 2021
jasnell
pushed a commit
that referenced
this pull request
Apr 14, 2021
`value` was always being assigned to an `undefined` property of an Array. Thus, the assertions that depended on `value` being defined were never being checked. Assign `value` the correct...er...value. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 14, 2021
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 14, 2021
Minor changes mostly to improve compliance with our style guide. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
`value` was always being assigned to an `undefined` property of an Array. Thus, the assertions that depended on `value` being defined were never being checked. Assign `value` the correct...er...value. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
Minor changes mostly to improve compliance with our style guide. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
`value` was always being assigned to an `undefined` property of an Array. Thus, the assertions that depended on `value` being defined were never being checked. Assign `value` the correct...er...value. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Minor changes mostly to improve compliance with our style guide. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
`value` was always being assigned to an `undefined` property of an Array. Thus, the assertions that depended on `value` being defined were never being checked. Assign `value` the correct...er...value. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
Minor changes mostly to improve compliance with our style guide. PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.