test: Update test-http-parser-free to use countdown timer · nodejs/node@b033d38 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b033d38

Browse filesBrowse the repository at this point in the historyBrowse files

daxlab

authored and

MylesBorins

committed

test: Update test-http-parser-free to use countdown timer

PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 4a749c3 commit b033d38
Copy full SHA for b033d38

1 file changed

+4-8Lines changed: 4 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-parser-free.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-parser-free.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-parser-free.js

+4-8Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -23,13 +23,15 @@
23	23	require('../common');
24	24	const assert = require('assert');
25	25	const http = require('http');
	26	+ const Countdown = require('../common/countdown');
26	27	const N = 100;
27		- let responses = 0;
28	28
29	29	const server = http.createServer(function(req, res) {
30	30	res.end('Hello');
31	31	});
32	32
	33	+ const countdown = new Countdown(N, () => server.close());
	34	+
33	35	server.listen(0, function() {
34	36	http.globalAgent.maxSockets = 1;
35	37	let parser;
@@ -42,15 +44,9 @@ server.listen(0, function() {
42	44	assert.strictEqual(req.parser, parser);
43	45	}
44	46
45		- if (++responses === N) {
46		- server.close();
47		- }
	47	+ countdown.dec();
48	48	res.resume();
49	49	});
50	50	})(i);
51	51	}
52	52	});
53		-
54		- process.on('exit', function() {
55		- assert.strictEqual(responses, N);
56		- });

0 commit comments

Comments

0 (0)