FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: Update test-http-parser-free to use countdown timer by daxlab · Pull Request #17322 · nodejs/node · GitHub

/ node Public

test: Update test-http-parser-free to use countdown timer - #17322

Closed
daxlab wants to merge 3 commits into
nodejs:masterfrom
daxlab:test-http-parser-free
ConversationCommits (3)ChecksFiles changed
Closed

test: Update test-http-parser-free to use countdown timer#17322
daxlab wants to merge 3 commits into
nodejs:masterfrom
daxlab:test-http-parser-free

Conversation

daxlab commented Nov 26, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
daxlab force-pushed the test-http-parser-free branch from db88f70 to ad7608f Compare November 26, 2017 14:07
mscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
maclover7 approved these changes Nov 26, 2017
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One comment, otherwise LGTM

Comment thread test/parallel/test-http-parser-free.js Outdated
}
});

process.on('exit', function() {

maclover7 Nov 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we still need this check? Doesn't server.close() / end of execution from the Countdown mean we've already hit zero remaining?

cc @jasnell

jasnell Nov 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yep, the process.on('exit') can be removed.

jasnell approved these changes Nov 26, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the process.on('exit') handler removed.

daxlab commented Nov 26, 2017

Copy link
Copy Markdown
Contributor Author

LGTM with the process.on('exit') handler removed.

Done.

jasnell commented Nov 26, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11730/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 27, 2017

addaleax commented Nov 28, 2017

Copy link
Copy Markdown
Member

Landed in 6d1f8a3

addaleax closed this Nov 28, 2017
addaleax pushed a commit that referenced this pull request Nov 28, 2017
test: Update test-http-parser-free to use countdown timer
6d1f8a3 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 28, 2017
daxlab deleted the test-http-parser-free branch November 28, 2017 04:53
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: Update test-http-parser-free to use countdown timer
a7455f7 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: Update test-http-parser-free to use countdown timer
7a68fda 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: Update test-http-parser-free to use countdown timer
b033d38 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: Update test-http-parser-free to use countdown timer
f3c1158 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: Update test-http-parser-free to use countdown timer
80d1671 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: Update test-http-parser-free to use countdown timer
74d5e6b 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
+1 more reviewer
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tracking issue] Converting tests to use Countdown

7 participants

Back | FazBrowse Home | New Git URL