deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init · nodejs/node@b411114 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b411114

Browse filesBrowse the repository at this point in the historyBrowse files

refack

authored and

targos

committed

deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init

`std::atomic_init<size_t>` is not implemented in all platforms. * pragma to ignore `-Wbraced-scalar-init` Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent c08d94b commit b411114
Copy full SHA for b411114

2 files changed

+9-2Lines changed: 9 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi
• deps/v8/src/wasm
  • module-compiler.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -38,7 +38,7 @@
38	38
39	39	# Reset this number to 0 on major V8 upgrades.
40	40	# Increment by one for each non-official patch applied to deps/v8.
41		- 'v8_embedder_string': '-node.8',
	41	+ 'v8_embedder_string': '-node.9',
42	42
43	43	##### V8 defaults for Node.js #####
44	44

Collapse file

‎deps/v8/src/wasm/module-compiler.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/module-compiler.cc

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -131,7 +131,14 @@ class CompilationUnitQueues {
131	131	queues_[task_id].next_steal_task_id_ = next_task_id(task_id);
132	132	}
133	133	for (auto& atomic_counter : num_units_) {
134		- std::atomic_init(&atomic_counter, size_t{0});
	134	+ #ifdef __clang__
	135	+ #pragma clang diagnostic push
	136	+ #pragma clang diagnostic ignored "-Wbraced-scalar-init"
	137	+ #endif
	138	+ atomic_counter = ATOMIC_VAR_INIT(0);
	139	+ #ifdef __clang__
	140	+ #pragma clang diagnostic pop
	141	+ #endif
135	142	}
136	143	}
137	144

0 commit comments

Comments

0 (0)