deps: update V8 to 7.5 by targos · Pull Request #27375 · nodejs/node · GitHub

Help wanted to fix remaining failures!

See #27375 (comment)

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3346

RSLGTM.

Thanks, @targos.

😄 what a happy little group

Wait, it didn't fail on linuxone? Let me start a full CI...

CI: https://ci.nodejs.org/job/node-test-pull-request/22666/

Wait, it didn't fail on linuxone? Let me start a full CI...

It's a liker issue, so it could arise from several reasons; (1) old compiled artifacts (2) C++ template mismatch (3) #ifdef...

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2252/

I think we can exclude (1). I can reproduce after a git clean -fdx

macOS:

22:20:58 ../deps/v8/src/torque/torque-compiler.cc:114:3: error: cannot use 'try' with exceptions disabled
22:20:58   try {
22:20:58   ^
22:20:58 ../deps/v8/src/torque/torque-compiler.cc:132:3: error: cannot use 'try' with exceptions disabled
22:20:58   try {
22:20:58   ^
22:20:58 2 errors generated.
22:20:58 make[2]: *** [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj.host/torque_base/deps/v8/src/torque/torque-compiler.o] Error 1

I fixed that issue on Linux with d46ee3e#diff-30246878345a874b2105006560a03f27R2530

Errors on Windows:

Details

22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Context::GetEmbedderData(int)" (?GetEmbedderData@Context@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) referenced in function "public: __cdecl v8::EscapableHandleScope::~EscapableHandleScope(void)" (??1EscapableHandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Context::GetEmbedderData(int)" (?GetEmbedderData@Context@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) referenced in function "public: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResource(void)const " (?GetExternalStringResource@String@v8@@QEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) referenced in function "public: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBase(enum v8::String::Encoding *)const " (?GetExternalStringResourceBase@String@v8@@QEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) referenced in function "public: static int __cdecl v8::Object::InternalFieldCount(class v8::PersistentBase<class v8::Object> const &)" (?InternalFieldCount@Object@v8@@SAHAEBV?$PersistentBase@VObject@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) referenced in function "public: static class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(class v8::PersistentBase<class v8::Object> const &)" (?CreationContext@Object@v8@@SA?AV?$Local@VContext@v8@@@2@AEBV?$PersistentBase@VObject@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Object::GetInternalField(int)" (?GetInternalField@Object@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) referenced in function "public: void * __cdecl v8::Object::GetAlignedPointerFromInternalField(int)" (?GetAlignedPointerFromInternalField@Object@v8@@QEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) referenced in function "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) referenced in function "public: bool __cdecl v8::ArrayBuffer::IsNeuterable(void)const " (?IsNeuterable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) referenced in function "public: void __cdecl v8::ArrayBuffer::Neuter(void)" (?Neuter@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) referenced in function "public: void __cdecl v8::ObjectTemplate::SetIndexedPropertyHandler(void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Value> const &),void (__cdecl*)(unsigned int,class v8::Local<class v8::Value>,class v8::PropertyCallbackInfo<class v8::Value> const &),void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Integer> const &),void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Boolean> const &),void (__cdecl*)(class v8::PropertyCallbackInfo<class v8::Array> const &),class v8::Local<class v8::Value>)" (?SetIndexedPropertyHandler@ObjectTemplate@v8@@QEAAXP6AXIAEBV?$PropertyCallbackInfo@VValue@v8@@@2@@ZP6AXIV?$Local@VValue@v8@@@2@0@ZP6AXIAEBV?$PropertyCallbackInfo@VInteger@v8@@@2@@ZP6AXIAEBV?$PropertyCallbackInfo@VBoolean@v8@@@2@@ZP6AXAEBV?$PropertyCallbackInfo@VArray@v8@@@2@@Z2@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) referenced in function "public: __cdecl v8::Isolate::Scope::Scope(class v8::Isolate *)" (??0Scope@Isolate@v8@@QEAA@PEAV12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) referenced in function "public: __cdecl v8::Isolate::Scope::~Scope(void)" (??1Scope@Isolate@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) referenced in function "public: __int64 __cdecl v8::Isolate::AdjustAmountOfExternalAllocatedMemory(__int64)" (?AdjustAmountOfExternalAllocatedMemory@Isolate@v8@@QEAA_J_J@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) referenced in function "public: __int64 __cdecl v8::Isolate::AdjustAmountOfExternalAllocatedMemory(__int64)" (?AdjustAmountOfExternalAllocatedMemory@Isolate@v8@@QEAA_J_J@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) referenced in function "private: __cdecl v8::WasmModuleObjectBuilderStreaming::WasmModuleObjectBuilderStreaming(class v8::WasmModuleObjectBuilderStreaming &&)" (??0WasmModuleObjectBuilderStreaming@v8@@AEAA@$$QEAV01@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) referenced in function "public: __cdecl v8::WasmModuleObjectBuilderStreaming::~WasmModuleObjectBuilderStreaming(void)" (??1WasmModuleObjectBuilderStreaming@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) referenced in function "public: void __cdecl v8::SnapshotCreator::`default constructor closure'(void)" (??_FSnapshotCreator@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) referenced in function "public: __cdecl v8::Unlocker::Unlocker(class v8::Isolate *)" (??0Unlocker@v8@@QEAA@PEAVIsolate@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) referenced in function "public: __cdecl v8::Locker::Locker(class v8::Isolate *)" (??0Locker@v8@@QEAA@PEAVIsolate@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) referenced in function "public: static void * __cdecl v8::internal::Malloced::operator new(unsigned __int64)" (??2Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) referenced in function "public: static void __cdecl v8::internal::Malloced::operator delete(void *)" (??3Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) referenced in function "public: __cdecl v8::internal::VirtualMemory::VirtualMemory(class v8::internal::VirtualMemory &&)" (??0VirtualMemory@internal@v8@@QEAA@$$QEAV012@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 ..\..\out\Release\bytecode_builtins_list_generator.exe : fatal error LNK1120: 38 unresolved externals [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]

plinux i.e. gcc-6 on ubuntu1404 over PPC64-LE:

  LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni; "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/mksnapshot" --turbo_instruction_scheduling --embedded_variant Default --embedded_src "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni/embedded.S" --startup_src "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni/snapshot.cc"
Segmentation fault (core dumped)

Well, there a bit of more gyp refactoring needed to mirror the changes in BUILD.gn https://github.com/nodejs/node/blob/2fef4d2f22b9f42042dcd96374e01dfc736bd782/deps/v8/BUILD.gn#diff-75477e7cdd271be767e5255488ca45e1.
A few of the dependencies have been moved around... I'll get to it soon.

node/tools/icu/icu_versions.json

Line 2 in 1a54d0f

"minimum_icu": 63

should be bumped in this PR to raise the minimum supported version of ICU.

@targos did we not plan to land 7.5 in v12? Or are we going to open a special backport later that contains commits to make it ABI compatible?

@targos did we not plan to land 7.5 in v12? Or are we going to open a special backport later that contains commits to make it ABI compatible?

@BridgeAR see #25082.

@BridgeAR The latter. Let's make it work without changes first.

please delete obsolete ICU patches

Builds and tests pass w/ refack@6720bd3

Xcode 10.2.1
Build version 10E1001
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.5.0
Thread model: posix

@refack, sorry if I missed it somewhere in this long thread, but can you explain why 702331b was necessary as part of this PR?

why 702331b was necessary as part of this PR?

V8 7.5 is now doing it natively (both BOM and shebang, and proper combinations of), so our code was doing unnecessary work, and it's tests were failing (mostly the ones who expected failures).
This PR landed as semver-major so avoiding breakage was not a priority, but if we find this commit is causing regressions in the ecosystem, we should revert and patch it.

Refs:
https://github.com/tc39/proposal-hashbang
v8/v8@0cd67eb

OK. Thanks for the info.

targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. labels Apr 23, 2019

nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Apr 23, 2019

targos added blocked PRs that are blocked by other issues or PRs. and removed build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Apr 23, 2019

ryzokuken approved these changes Apr 23, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

vsemozhetbyt added the v8 engine Issues and PRs related to the V8 dependency. label Apr 23, 2019

refack self-assigned this Apr 23, 2019

srl295 previously requested changes Apr 25, 2019

View reviewed changes

Comment thread tools/icu/icu_versions.json Outdated

targos force-pushed the v8-7.5 branch from 5e8ce2d to bcffaed Compare April 25, 2019 19:48

ryzokuken approved these changes Apr 27, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

targos deleted the v8-7.5 branch June 1, 2019 20:26

targos mentioned this pull request Jun 17, 2019

lib: rework logic of stripping BOM+Shebang from commonjs #27768

Merged

3 tasks

BridgeAR mentioned this pull request Jun 17, 2019

v12.5.0 proposal #28268

Merged

targos mentioned this pull request Aug 19, 2019

v12.9.0 release proposal #29210

Merged

BethGriggs mentioned this pull request Sep 9, 2019

2019-10-22, Version 13.0.0 (Current) #29504

Merged

BridgeAR mentioned this pull request Sep 24, 2019

v12.11.0 proposal #29695

Merged

sam-github mentioned this pull request Sep 26, 2019

12.11.0 on PPCLE requires libatomic.so.1 #29718

Closed

BridgeAR mentioned this pull request Nov 21, 2019

v13.2.0 proposal #30547

Merged

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

bcoe mentioned this pull request Oct 24, 2020

fix: drop special shebang handling istanbuljs/v8-to-istanbul#125

Merged

deps: update V8 to 7.5 by targos · Pull Request #27375 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: update V8 to 7.5 - #27375

deps: update V8 to 7.5#27375refack merged 22 commits intonodejs:masternodejs/node:masterfrom targos:v8-7.5targos/node:v8-7.5Copy head branch name to clipboard

Conversation

targos commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 23, 2019

Uh oh!

ryzokuken left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 23, 2019

Uh oh!

nodejs-github-bot commented Apr 23, 2019

Uh oh!

refack commented Apr 23, 2019

Uh oh!

targos commented Apr 23, 2019

Uh oh!

targos commented Apr 23, 2019

Uh oh!

targos commented Apr 23, 2019

Uh oh!

targos commented Apr 23, 2019

Uh oh!

This comment has been minimized.

refack commented Apr 23, 2019

Uh oh!

refack commented Apr 23, 2019

Uh oh!

richardlau commented Apr 24, 2019

Uh oh!

BridgeAR commented Apr 24, 2019

Uh oh!

richardlau commented Apr 24, 2019

Uh oh!

targos commented Apr 24, 2019

Uh oh!

srl295 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ryzokuken left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

cjihrig commented Jun 1, 2019

Uh oh!

refack commented Jun 1, 2019

Uh oh!

cjihrig commented Jun 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

deps: update V8 to 7.5#27375
refack merged 22 commits into
nodejs:masterfrom
targos:v8-7.5

targos commented Apr 23, 2019 •
edited
Loading

refack commented Apr 23, 2019 •
edited
Loading