Commit b502be1
tools: disable automated libuv updates
Because the previous security release modified the bundled version of
libuv, we cannot automatically update libuv without potentially undoing
those changes.
PR-URL: #51775
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent f845a16 commit b502be1
1 file changed
Lines changed: 12 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,7 +27,7 @@ on: | |||
| 27 | 27 | - googletest | |
| 28 | 28 | - histogram | |
| 29 | 29 | - icu | |
| 30 | - - libuv | ||
| 30 | + # - libuv | ||
| 31 | 31 | - lint-md-dependencies | |
| 32 | 32 | - llhttp | |
| 33 | 33 | - minimatch | |
@@ -174,14 +174,17 @@ jobs: | |||
| 174 | 174 | cat temp-output | |
| 175 | 175 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 176 | 176 | rm temp-output | |
| 177 | - - id: libuv | ||
| 178 | - subsystem: deps | ||
| 179 | - label: dependencies | ||
| 180 | - run: | | ||
| 181 | - ./tools/dep_updaters/update-libuv.sh > temp-output | ||
| 182 | - cat temp-output | ||
| 183 | - tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | ||
| 184 | - rm temp-output | ||
| 177 | + # libuv update was disabled because of Feb 14, 2024 security releas | ||
| 178 | + # modified the bundled version of libuv, we cannot automatically update | ||
| 179 | + # libuv without potentially undoing those changes. | ||
| 180 | + # - id: libuv | ||
| 181 | + # subsystem: deps | ||
| 182 | + # label: dependencies | ||
| 183 | + # run: | | ||
| 184 | + # ./tools/dep_updaters/update-libuv.sh > temp-output | ||
| 185 | + # cat temp-output | ||
| 186 | + # tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | ||
| 187 | + # rm temp-output | ||
| 185 | 188 | - id: lint-md-dependencies | |
| 186 | 189 | subsystem: tools | |
| 187 | 190 | label: tools | |
0 commit comments