tools: disable automated libuv updates - #51775
Merged
nodejs-github-bot merged 1 commit intoFeb 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
6359c62 to
9f8e928
Compare
February 15, 2024 20:38
mhdawson
reviewed
Feb 15, 2024
Comment thread
.github/workflows/tools.yml
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can we just comment this out instead of removing, I assume we will want to add it back at some point?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The other question is if we could have the update apply a patch required to re-apply the changes?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I don't know, technically we could, but we'll need to review it carefully all libuv automatic updates + resolve conflicts.
Sorry, something went wrong.
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
9f8e928 to
a2fba64
Compare
February 19, 2024 14:18
edsadr
reviewed
Feb 19, 2024
Comment thread
.github/workflows/tools.yml
Outdated
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
a2fba64 to
847748d
Compare
February 19, 2024 21:16
Copy link
Copy Markdown
Member
Author
|
ping @nodejs/actions @nodejs/security-wg |
Sorry, something went wrong.
joyeecheung
approved these changes
Feb 23, 2024
marco-ippolito
approved these changes
Feb 23, 2024
UlisesGascon
approved these changes
Feb 23, 2024
UlisesGascon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
cc: @nodejs/security-wg