zlib: refactor to use primordial instead of <string>.startsWith · nodejs/node@b6f74b0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b6f74b0

Browse filesBrowse the repository at this point in the historyBrowse files

rchougule

authored and

danielleadams

committed

zlib: refactor to use primordial instead of <string>.startsWith

PR-URL: #36718 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>

1 parent d70824f commit b6f74b0
Copy full SHA for b6f74b0

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • zlib.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/zlib.js‎

Copy file name to clipboardExpand all lines: lib/zlib.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -37,6 +37,7 @@ const {
37	37	ObjectKeys,
38	38	ObjectSetPrototypeOf,
39	39	ReflectApply,
	40	+ StringPrototypeStartsWith,
40	41	Symbol,
41	42	TypedArrayPrototypeFill,
42	43	Uint32Array,
@@ -786,7 +787,9 @@ function createConvenienceMethod(ctor, sync) {
786	787
787	788	const kMaxBrotliParam = MathMax(...ArrayPrototypeMap(
788	789	ObjectKeys(constants),
789		- (key) => (key.startsWith('BROTLI_PARAM_') ? constants[key] : 0)
	790	+ (key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
	791	+ constants[key] :
	792	+ 0)
790	793	));
791	794
792	795	const brotliInitParamsArray = new Uint32Array(kMaxBrotliParam + 1);
@@ -927,7 +930,7 @@ ObjectDefineProperties(module.exports, {
927	930	// These should be considered deprecated
928	931	// expose all the zlib constants
929	932	for (const bkey of ObjectKeys(constants)) {
930		- if (bkey.startsWith('BROTLI')) continue;
	933	+ if (StringPrototypeStartsWith(bkey, 'BROTLI')) continue;
931	934	ObjectDefineProperty(module.exports, bkey, {
932	935	enumerable: false, value: constants[bkey], writable: false
933	936	});

0 commit comments

Comments

0 (0)