FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: refactor to use primordial instead of <string>.startsWith by rchougule · Pull Request #36718 · nodejs/node · GitHub

/ node Public

zlib: refactor to use primordial instead of <string>.startsWith - #36718

Closed
rchougule wants to merge 1 commit into
nodejs:masterfrom
rchougule:zlib_string_primordials
ConversationCommits (1)ChecksFiles changed
Closed

zlib: refactor to use primordial instead of <string>.startsWith#36718
rchougule wants to merge 1 commit into
nodejs:masterfrom
rchougule:zlib_string_primordials

Conversation

rchougule commented Jan 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Jan 1, 2021
Lxxyx approved these changes Jan 1, 2021
View reviewed changes

Lxxyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM except one nit.

I suggest the first word of the commit message should be an imperative verb, something like zlib: refactor to use primordials instead of StringPrototypeStartsWith. Refs: #36679 (comment)

rchougule force-pushed the zlib_string_primordials branch from fcf85c0 to 0665753 Compare January 1, 2021 12:59

rchougule commented Jan 1, 2021

Copy link
Copy Markdown
Contributor Author

LGTM except one nit.

I suggest the first word of the commit message should be an imperative verb, something like zlib: refactor to use primordials instead of StringPrototypeStartsWith. Refs: #36679 (comment)

Ah yes. My bad. Addressed in 0665753

rchougule changed the title zlib: StringPrototypeStartsWith primordial instead of <string>.startsWith zlib: refactor to use primordial instead of <string>.startsWith Jan 1, 2021
aduh95 approved these changes Jan 1, 2021
View reviewed changes
Comment thread lib/zlib.js
Comment on lines +790 to +792
(key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
constants[key] :
0)

aduh95 Jan 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: I find it easier to read on one line, but you can leave it as is if you prefer.

Suggested change
(key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
constants[key] :
0)
(key) =>
(StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ? constants[key] : 0)

yashLadha added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 8, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35380/

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35406/

yashLadha commented Jan 10, 2021

Copy link
Copy Markdown
Contributor

Landed in 7a6af02

yashLadha closed this Jan 10, 2021
yashLadha pushed a commit that referenced this pull request Jan 10, 2021
zlib: refactor to use primordial instead of <string>.startsWith
7a6af02 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
rchougule deleted the zlib_string_primordials branch January 10, 2021 09:17
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
zlib: refactor to use primordial instead of <string>.startsWith
b6f74b0 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
zlib: refactor to use primordial instead of <string>.startsWith
161e805 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos pushed a commit that referenced this pull request May 30, 2021
zlib: refactor to use primordial instead of <string>.startsWith
a6aad06 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
zlib: refactor to use primordial instead of <string>.startsWith
0131ecf 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
zlib: refactor to use primordial instead of <string>.startsWith
740638d 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
Lxxyx Lxxyx approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL