Commit c0e829f
deps: V8: fix BUILDING_V8_SHARED issues
Backport-PR-URL: #30109
PR-URL: #27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 02b54af commit c0e829f
4 files changed
Lines changed: 7 additions & 1 deletion
File tree
- deps/v8/src
- init
- objects
- snapshot
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.7', | ||
| 41 | + 'v8_embedder_string': '-node.8', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,6 +7,7 @@ | |||
| 7 | 7 | #include "src/base/logging.h" | |
| 8 | 8 | #include "src/execution/isolate.h" | |
| 9 | 9 | #include "src/interpreter/interpreter.h" | |
| 10 | + #include "src/objects/objects-inl.h" | ||
| 10 | 11 | #include "src/utils/ostreams.h" | |
| 11 | 12 | ||
| 12 | 13 | namespace v8 { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -957,6 +957,7 @@ OrderedHashTableHandler<SmallOrderedNameDictionary, | |||
| 957 | 957 | OrderedNameDictionary>::Allocate(Isolate* isolate, | |
| 958 | 958 | int capacity); | |
| 959 | 959 | ||
| 960 | + #if !defined(V8_OS_WIN) | ||
| 960 | 961 | template <class SmallTable, class LargeTable> | |
| 961 | 962 | bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete( | |
| 962 | 963 | Handle<HeapObject> table, Handle<Object> key) { | |
@@ -969,7 +970,9 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete( | |||
| 969 | 970 | // down to a smaller hash table. | |
| 970 | 971 | return LargeTable::Delete(Handle<LargeTable>::cast(table), key); | |
| 971 | 972 | } | |
| 973 | + #endif | ||
| 972 | 974 | ||
| 975 | + #if !defined(V8_OS_WIN) | ||
| 973 | 976 | template <class SmallTable, class LargeTable> | |
| 974 | 977 | bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey( | |
| 975 | 978 | Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) { | |
@@ -980,6 +983,7 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey( | |||
| 980 | 983 | DCHECK(LargeTable::Is(table)); | |
| 981 | 984 | return LargeTable::HasKey(isolate, LargeTable::cast(*table), *key); | |
| 982 | 985 | } | |
| 986 | + #endif | ||
| 983 | 987 | ||
| 984 | 988 | template bool | |
| 985 | 989 | OrderedHashTableHandler<SmallOrderedHashSet, OrderedHashSet>::HasKey( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,6 +8,7 @@ | |||
| 8 | 8 | #include "src/snapshot/partial-serializer.h" | |
| 9 | 9 | #include "src/snapshot/startup-serializer.h" | |
| 10 | 10 | ||
| 11 | + #include "src/objects/objects-inl.h" | ||
| 11 | 12 | #include "src/utils/utils.h" | |
| 12 | 13 | ||
| 13 | 14 | namespace v8 { | |
0 commit comments