Commit c4833ff
src: remove SecureContext::operator*
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().
PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 745d9a2 commit c4833ff
2 files changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -209,7 +209,7 @@ const char* GetServerName(SSL* ssl) { | |||
| 209 | 209 | } | |
| 210 | 210 | ||
| 211 | 211 | bool SetGroups(SecureContext* sc, const char* groups) { | |
| 212 | - return SSL_CTX_set1_groups_list(**sc, groups) == 1; | ||
| 212 | + return SSL_CTX_set1_groups_list(sc->ssl_ctx(), groups) == 1; | ||
| 213 | 213 | } | |
| 214 | 214 | ||
| 215 | 215 | const char* X509ErrorCode(long err) { // NOLINT(runtime/int) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,8 +41,6 @@ class SecureContext final : public BaseObject { | |||
| 41 | 41 | static void RegisterExternalReferences(ExternalReferenceRegistry* registry); | |
| 42 | 42 | static SecureContext* Create(Environment* env); | |
| 43 | 43 | ||
| 44 | - SSL_CTX* operator*() const { return ctx_.get(); } | ||
| 45 | - | ||
| 46 | 44 | SSL_CTX* ssl_ctx() const { return ctx_.get(); } | |
| 47 | 45 | ||
| 48 | 46 | SSLPointer CreateSSL(); | |
0 commit comments