src: remove SecureContext::operator* - #43121
Merged
nodejs-github-bot merged 1 commit intoMay 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx().
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
This comment was marked as outdated.
23 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
May 17, 2022
joyeecheung
approved these changes
May 17, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43121 ✔ Done loading data for nodejs/node/pull/43121 ----------------------------------- PR info ------------------------------------ Title src: remove SecureContext::operator* (#43121) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:src-crypto-remove-securecontext-operatorast -> nodejs:master Labels crypto, c++, fast-track, author ready, needs-ci Commits 1 - src: remove SecureContext::operator* Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43121 Reviewed-By: Luigi Pinca Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43121 Reviewed-By: Luigi Pinca Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 16 May 2022 20:39:16 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43121#pullrequestreview-975353507 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43121#pullrequestreview-975409202 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-17T04:03:53Z: https://ci.nodejs.org/job/node-test-pull-request/44041/ - Querying data for job/node-test-pull-request/44041/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2338846785 |
Sorry, something went wrong.
RaisinTen
approved these changes
May 17, 2022
This was referenced May 18, 2022
This was referenced May 21, 2022
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: nodejs/node#43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx().