test: add test case to test-http-response-statuscode.js · nodejs/node@c740cb6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c740cb6

Browse filesBrowse the repository at this point in the historyBrowse files

abouthiroppy

authored and

MylesBorins

committed

test: add test case to test-http-response-statuscode.js

Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 8723545 commit c740cb6
Copy full SHA for c740cb6

1 file changed

+23-14Lines changed: 23 additions & 14 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-response-statuscode.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-response-statuscode.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-response-statuscode.js

+23-14Lines changed: 23 additions & 14 deletions

Original file line number	Diff line number	Diff line change
@@ -3,70 +3,79 @@ const common = require('../common');
3	3	const assert = require('assert');
4	4	const http = require('http');
5	5
6		- const MAX_REQUESTS = 12;
7		- var reqNum = 0;
	6	+ const MAX_REQUESTS = 13;
	7	+ let reqNum = 0;
	8	+
	9	+ const createErrorMessage = (code) => {
	10	+ return new RegExp(`^RangeError: Invalid status code: ${code}$`);
	11	+ };
8	12
9	13	const server = http.Server(common.mustCall(function(req, res) {
10	14	switch (reqNum) {
11	15	case 0:
12	16	assert.throws(common.mustCall(() => {
13	17	res.writeHead(-1);
14		- }), /invalid status code/i);
	18	+ }), createErrorMessage(-1));
15	19	break;
16	20	case 1:
17	21	assert.throws(common.mustCall(() => {
18	22	res.writeHead(Infinity);
19		- }), /invalid status code/i);
	23	+ }), createErrorMessage(0));
20	24	break;
21	25	case 2:
22	26	assert.throws(common.mustCall(() => {
23	27	res.writeHead(NaN);
24		- }), /invalid status code/i);
	28	+ }), createErrorMessage(0));
25	29	break;
26	30	case 3:
27	31	assert.throws(common.mustCall(() => {
28	32	res.writeHead({});
29		- }), /invalid status code/i);
	33	+ }), createErrorMessage(0));
30	34	break;
31	35	case 4:
32	36	assert.throws(common.mustCall(() => {
33	37	res.writeHead(99);
34		- }), /invalid status code/i);
	38	+ }), createErrorMessage(99));
35	39	break;
36	40	case 5:
37	41	assert.throws(common.mustCall(() => {
38	42	res.writeHead(1000);
39		- }), /invalid status code/i);
	43	+ }), createErrorMessage(1000));
40	44	break;
41	45	case 6:
42	46	assert.throws(common.mustCall(() => {
43	47	res.writeHead('1000');
44		- }), /invalid status code/i);
	48	+ }), createErrorMessage(1000));
45	49	break;
46	50	case 7:
47	51	assert.throws(common.mustCall(() => {
48	52	res.writeHead(null);
49		- }), /invalid status code/i);
	53	+ }), createErrorMessage(0));
50	54	break;
51	55	case 8:
52	56	assert.throws(common.mustCall(() => {
53	57	res.writeHead(true);
54		- }), /invalid status code/i);
	58	+ }), createErrorMessage(1));
55	59	break;
56	60	case 9:
57	61	assert.throws(common.mustCall(() => {
58	62	res.writeHead([]);
59		- }), /invalid status code/i);
	63	+ }), createErrorMessage(0));
60	64	break;
61	65	case 10:
62	66	assert.throws(common.mustCall(() => {
63	67	res.writeHead('this is not valid');
64		- }), /invalid status code/i);
	68	+ }), createErrorMessage(0));
65	69	break;
66	70	case 11:
67	71	assert.throws(common.mustCall(() => {
68	72	res.writeHead('404 this is not valid either');
69		- }), /invalid status code/i);
	73	+ }), createErrorMessage(0));
	74	+ break;
	75	+ case 12:
	76	+ assert.throws(common.mustCall(() => {
	77	+ res.writeHead();
	78	+ }), createErrorMessage(0));
70	79	this.close();
71	80	break;
72	81	default:

0 commit comments

Comments

0 (0)