test: add test case to test-http-response-statuscode.js - #10808
Closed
hiroppy wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Change regular expression of error message. Add test case(`res.writeHead()`).
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Finished Build : #5922 of Job : node-test-binary-windows with status : FAILURE hmm... I don't understand the cause. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@abouthiroppy looks like a machine went offline (or a network problem) during the build. The test you changed passed, so almost certainly unrelated. CI 2: https://ci.nodejs.org/job/node-test-commit/7248/ EDIT: CI 2 was green Failure:ok 231 parallel/test-stream-pipe-await-drain-manual-resume --- duration_ms: 0.250 ... FATAL: command execution failed hudson.remoting.ChannelClosedException: channel is already closed ... Caused by: java.io.IOException: Connection aborted: org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport@17c7fdc0[name=Channel to /104.239.231.190] ... Caused by: java.io.IOException: Connection timed out ... ... 6 more |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@gibfahn Ah, I see. Thanks for running CI again. |
Sorry, something went wrong.
lpinca
approved these changes
Jan 15, 2017
jasnell
approved these changes
Jan 15, 2017
cjihrig
approved these changes
Jan 15, 2017
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jan 16, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: nodejs#10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: nodejs#10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: nodejs#10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: nodejs#10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in v6. A backport PR would be required for this to land in v4 |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change regular expression of error message.
Add test case(res.writeHead()).
Checklist
Affected core subsystem(s)
test