src: make parameter name const reference in method TriggerNodeReport · nodejs/node@c7bd21c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c7bd21c

Browse filesBrowse the repository at this point in the historyBrowse files

gengjiawen

authored and

BridgeAR

committed

src: make parameter name const reference in method TriggerNodeReport

PR-URL: #26397 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent bb374d4 commit c7bd21c
Copy full SHA for c7bd21c

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_report.cc
  • node_report.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_report.cc‎

Copy file name to clipboardExpand all lines: src/node_report.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -99,7 +99,7 @@ std::string TriggerNodeReport(Isolate* isolate,
99	99	Environment* env,
100	100	const char* message,
101	101	const char* trigger,
102		- std::string name,
	102	+ const std::string& name,
103	103	Local<String> stackstr) {
104	104	std::ostringstream oss;
105	105	std::string filename;

Collapse file

‎src/node_report.h‎

Copy file name to clipboardExpand all lines: src/node_report.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -44,7 +44,7 @@ std::string TriggerNodeReport(v8::Isolate* isolate,
44	44	node::Environment* env,
45	45	const char* message,
46	46	const char* trigger,
47		- std::string name,
	47	+ const std::string& name,
48	48	v8::Local<v8::String> stackstr);
49	49	void GetNodeReport(v8::Isolate* isolate,
50	50	node::Environment* env,

0 commit comments

Comments

0 (0)