FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: make parameter name const reference in method TriggerNodeReport by gengjiawen · Pull Request #26397 · nodejs/node · GitHub

/ node Public

src: make parameter name const reference in method TriggerNodeReport - #26397

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:string_const_ref
ConversationCommits (1)ChecksFiles changed
Closed

src: make parameter name const reference in method TriggerNodeReport#26397
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:string_const_ref

Conversation

gengjiawen commented Mar 2, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 2, 2019
richardlau added the report Issues and PRs related to process.report. label Mar 2, 2019

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

@gengjiawen this needs a rebase

gengjiawen commented Mar 6, 2019 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Member Author

@BridgeAR Done.

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21267/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 6, 2019

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21283/

danbev commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Landed in d08a574.

danbev closed this Mar 7, 2019
danbev pushed a commit that referenced this pull request Mar 7, 2019
src: make parameter name const reference in method TriggerNodeReport
d08a574 
PR-URL: #26397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gengjiawen deleted the string_const_ref branch March 7, 2019 04:12
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
src: make parameter name const reference in method TriggerNodeReport
539a9c0 
PR-URL: nodejs#26397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
src: make parameter name const reference in method TriggerNodeReport
c7bd21c 
PR-URL: #26397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL