Commit cbe5747
deps: switch to upstream v8_inspector
This change picks up v8_inspector directly from the upstream chromium
repository [1]; dropping the intermediate repository. The upstream
code has been refactored substantially to make it easy to share code
without adaptation with Node.js.
The deps/v8_inspector directory is now simply a gathering of
dependencies:
* platform/v8_inspector: vendored from [2].
* platform/inspector_protocol: vendored from [3].
* deps/jinja2: vendored from [4].
* deps/markupsafe: vendored from [5].
[1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform
[2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector
[3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol
[4]: https://github.com/mitsuhiko/jinja2
[5]: https://github.com/mitsuhiko/markupsafe
PR-URL: #7302
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>1 parent fb39025 commit cbe5747
94 files changed
Lines changed: 4713 additions & 11267 deletions
File tree
- deps/v8_inspector
- devtools
- platform
- inspector_protocol
- v8_inspector
- public
- src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -816,6 +816,7 @@ def configure_node(o): | |||
| 816 | 816 | ||
| 817 | 817 | o['variables']['asan'] = int(options.enable_asan or 0) | |
| 818 | 818 | o['variables']['v8_inspector'] = b(not options.without_inspector) | |
| 819 | + o['variables']['debug_devtools'] = 'node' | ||
| 819 | 820 | ||
| 820 | 821 | if options.use_xcode and options.use_ninja: | |
| 821 | 822 | raise Exception('--xcode and --ninja cannot be used together.') | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,2 +1,10 @@ | |||
| 1 | - # v8_inspector | ||
| 2 | - # v8_inspector | ||
| 1 | + V8 Inspector support for Node.js | ||
| 2 | + ================================ | ||
| 3 | + | ||
| 4 | + This directory is a gathering of dependencies for Node.js support for the | ||
| 5 | + [Chrome Debug Protocol][https://developer.chrome.com/devtools/docs/debugger-protocol]. | ||
| 6 | + | ||
| 7 | + * platform/v8_inspector: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector | ||
| 8 | + * platform/inspector_protocol: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol | ||
| 9 | + * deps/jinja2: vendored from https://github.com/mitsuhiko/jinja2 | ||
| 10 | + * deps/markupsafe: vendored from https://github.com/mitsuhiko/markupsafe | ||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,9 +5,9 @@ | |||
| 5 | 5 | #ifndef Array_h | |
| 6 | 6 | #define Array_h | |
| 7 | 7 | ||
| 8 | - #include "platform/PlatformExport.h" | ||
| 9 | 8 | #include "platform/inspector_protocol/Collections.h" | |
| 10 | 9 | #include "platform/inspector_protocol/ErrorSupport.h" | |
| 10 | + #include "platform/inspector_protocol/Platform.h" | ||
| 11 | 11 | #include "platform/inspector_protocol/String16.h" | |
| 12 | 12 | #include "platform/inspector_protocol/ValueConversions.h" | |
| 13 | 13 | #include "platform/inspector_protocol/Values.h" | |
@@ -91,7 +91,7 @@ class Array { | |||
| 91 | 91 | errors->addError("array expected"); | |
| 92 | 92 | return nullptr; | |
| 93 | 93 | } | |
| 94 | - std::unique_ptr<Array<T>> result = wrapUnique(new Array<T>()); | ||
| 94 | + std::unique_ptr<Array<T>> result(new Array<T>()); | ||
| 95 | 95 | errors->push(); | |
| 96 | 96 | for (size_t i = 0; i < array->size(); ++i) { | |
| 97 | 97 | errors->setName(String16::number(i)); | |
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,23 @@ | |||
| 1 | + // Copyright (c) 2016 The Chromium Authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + #ifndef BackendCallback_h | ||
| 6 | + #define BackendCallback_h | ||
| 7 | + | ||
| 8 | + #include "platform/inspector_protocol/ErrorSupport.h" | ||
| 9 | + #include "platform/inspector_protocol/Platform.h" | ||
| 10 | + | ||
| 11 | + namespace blink { | ||
| 12 | + namespace protocol { | ||
| 13 | + | ||
| 14 | + class PLATFORM_EXPORT BackendCallback { | ||
| 15 | + public: | ||
| 16 | + virtual ~BackendCallback() { } | ||
| 17 | + virtual void sendFailure(const ErrorString&) = 0; | ||
| 18 | + }; | ||
| 19 | + | ||
| 20 | + } // namespace platform | ||
| 21 | + } // namespace blink | ||
| 22 | + | ||
| 23 | + #endif // !defined(BackendCallback_h) | ||
Whitespace-only changes.
Lines changed: 0 additions & 78 deletions
This file was deleted.
0 commit comments