deps: switch to upstream v8_inspector - #7302
Conversation
Sorry, something went wrong.
|
sgtm https://ci.nodejs.org/job/node-test-commit/3749/ Is @nodejs/v8 going to be good to call for review on changes here or should we consider v8_inspector a separate concern and perhaps start calling on @nodejs/diagnostics?. |
Sorry, something went wrong.
|
Oh... this tightens our dependency on Python, though this PR SGTM. LGTM, if CI is green and @bnoordhuis is happy. |
Sorry, something went wrong.
|
Build failures on older GCC / Linux will need looking at https://ci.nodejs.org/job/node-test-commit-linux/3808/ |
Sorry, something went wrong.
|
Those are due to Python 2.6 on the CentOS machines; this CL fixes things upstream: https://codereview.chromium.org/2066423002/. Once the CL lands, I will update this PR. |
Sorry, something went wrong.
Sorry, something went wrong.
|
CI is green. @bnoordhuis: ready for your review. |
Sorry, something went wrong.
|
LGTM at a glance. |
Sorry, something went wrong.
This change picks up v8_inspector directly from the upstream chromium repository [1]; dropping the intermediate repository. The upstream code has been refactored substantially to make it easy to share code without adaptation with Node.js. The deps/v8_inspector directory is now simply a gathering of dependencies: * platform/v8_inspector: vendored from [2]. * platform/inspector_protocol: vendored from [3]. * deps/jinja2: vendored from [4]. * deps/markupsafe: vendored from [5]. [1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform [2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector [3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol [4]: https://github.com/mitsuhiko/jinja2 [5]: https://github.com/mitsuhiko/markupsafe PR-URL: nodejs#7302 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This change picks up v8_inspector directly from the upstream chromium repository [1]; dropping the intermediate repository. The upstream code has been refactored substantially to make it easy to share code without adaptation with Node.js. The deps/v8_inspector directory is now simply a gathering of dependencies: * platform/v8_inspector: vendored from [2]. * platform/inspector_protocol: vendored from [3]. * deps/jinja2: vendored from [4]. * deps/markupsafe: vendored from [5]. [1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform [2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector [3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol [4]: https://github.com/mitsuhiko/jinja2 [5]: https://github.com/mitsuhiko/markupsafe PR-URL: #7302 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Checklist
Affected core subsystem(s)
deps: v8_inspector
Description of change
This change picks up v8_inspector directly from the upstream chromium
repository 1; dropping the intermediate repository. The upstream
code has been refactored substantially to make it easy to share code
without adaptation with Node.js.
The deps/v8_inspector directory is now simply a gathering of
dependencies:
R=@bnoordhuis
/cc @pavelfeldman @eugeneo