Commit d03a235
deps: V8: cherry-pick 26fd1dfa9cd6
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 53bb21b commit d03a235
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.38', | ||
| 39 | + 'v8_embedder_string': '-node.39', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4761,6 +4761,20 @@ MaybeHandle<FixedArray> Isolate::GetImportAssertionsFromArgument( | |||
| 4761 | 4761 | // an error. | |
| 4762 | 4762 | return MaybeHandle<FixedArray>(); | |
| 4763 | 4763 | } | |
| 4764 | + | ||
| 4765 | + if (V8_UNLIKELY(!import_assertions_object->IsUndefined())) { | ||
| 4766 | + MessageLocation* location = nullptr; | ||
| 4767 | + MessageLocation computed_location; | ||
| 4768 | + if (ComputeLocation(&computed_location)) { | ||
| 4769 | + location = &computed_location; | ||
| 4770 | + } | ||
| 4771 | + Handle<JSMessageObject> message = MessageHandler::MakeMessageObject( | ||
| 4772 | + this, MessageTemplate::kImportAssertDeprecated, location, | ||
| 4773 | + factory()->NewStringFromAsciiChecked("a future version"), | ||
| 4774 | + Handle<FixedArray>::null()); | ||
| 4775 | + message->set_error_level(v8::Isolate::kMessageWarning); | ||
| 4776 | + MessageHandler::ReportMessage(this, location, message); | ||
| 4777 | + } | ||
| 4764 | 4778 | } | |
| 4765 | 4779 | ||
| 4766 | 4780 | // If there is no 'with' or 'assert' option in the options bag, it's not an | |
0 commit comments