FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x] Warning for import assertions by aduh95 · Pull Request #55873 · nodejs/node · GitHub

/ node Public

[v18.x] Warning for import assertions - #55873

Merged
aduh95 merged 3 commits into
nodejs:v18.x-stagingfrom
aduh95:warning-for-import-assertions
Feb 13, 2025
ConversationCommits (3)ChecksFiles changed
Merged

[v18.x] Warning for import assertions#55873
aduh95 merged 3 commits into
nodejs:v18.x-stagingfrom
aduh95:warning-for-import-assertions

Conversation

aduh95 commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Fixes: #55869

$ ./node --input-type=module -e 'import "data:application/json,{}" assert { type: "json" }'
(node:96221) V8: file:///Users/duhamean/Documents/node-v18.x/[eval1]:1 'assert' is deprecated in import statements and support will be removed in a future version; use 'with' instead
(Use `node --trace-warnings ...` to show where the warning was created)
$ echo $?
0
$ ./node --input-type=module -e 'import "data:application/json,{}" with { type: "json" }'
$ echo $?
0

nodejs-github-bot commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 15, 2024
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed release-agenda Issues and PRs to discuss during the meetings of the Release team. labels Feb 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025

nodejs-github-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65125/

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 force-pushed the warning-for-import-assertions branch from 912aecc to cc907e4 Compare February 10, 2025 21:35
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025

nodejs-github-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65131/

nodejs-github-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6406/

nodejs-github-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6406/

nodejs-github-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6406/

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65150/

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65151/

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65153/

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65164/

nodejs-github-bot commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65170/

aduh95 and others added 3 commits February 13, 2025 11:41
test: do not use deprecated import assertions
e74fcc7 
PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <rlau@redhat.com>
deps: V8: backport ae5a4db8ad86
80c8a66 
Original commit message:

    [import-attributes] Deprecate 'assert' for removal in 12.6

    See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ

    Bug: v8:10958
    Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
    Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#92044}

Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <rlau@redhat.com>
deps: V8: cherry-pick 26fd1dfa9cd6
45a1f2b 
Original commit message:

    [import-attributes] Deprecate 'assert' for dynamic import as well

    Bug: v8:10958
    Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#92123}

Refs: v8/v8@26fd1df
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 force-pushed the warning-for-import-assertions branch from cc907e4 to 45a1f2b Compare February 13, 2025 10:42

aduh95 commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Landed in 06c523d...d03a235

aduh95 merged commit 45a1f2b into nodejs:v18.x-staging Feb 13, 2025
aduh95 added a commit that referenced this pull request Feb 13, 2025
test: do not use deprecated import assertions
d47e8cb 
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 added a commit that referenced this pull request Feb 13, 2025
deps: V8: backport ae5a4db8ad86
53bb21b 
Original commit message:

    [import-attributes] Deprecate 'assert' for removal in 12.6

    See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ

    Bug: v8:10958
    Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
    Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#92044}

Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 added a commit that referenced this pull request Feb 13, 2025
deps: V8: cherry-pick 26fd1dfa9cd6
d03a235 
Original commit message:

    [import-attributes] Deprecate 'assert' for dynamic import as well

    Bug: v8:10958
    Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#92123}

Refs: v8/v8@26fd1df
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 deleted the warning-for-import-assertions branch February 13, 2025 10:43
github-actions Bot mentioned this pull request Feb 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL