http2: add constant to already destructured constants · nodejs/node@d0d3149 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d0d3149

Browse filesBrowse the repository at this point in the historyBrowse files

dnalborczyk

authored and

targos

committed

http2: add constant to already destructured constants

PR-URL: #28176 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 1b0d67b commit d0d3149
Copy full SHA for d0d3149

1 file changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/http2
  • compat.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/http2/compat.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/compat.js

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -4,9 +4,8 @@ const { Object, ObjectPrototype, Reflect } = primordials;
4	4
5	5	const assert = require('internal/assert');
6	6	const Stream = require('stream');
7		- const Readable = Stream.Readable;
8		- const binding = internalBinding('http2');
9		- const constants = binding.constants;
	7	+ const { Readable } = Stream;
	8	+ const { constants } = internalBinding('http2');
10	9	const {
11	10	codes: {
12	11	ERR_HTTP2_HEADERS_SENT,
@@ -38,6 +37,7 @@ const kAborted = Symbol('aborted');
38	37
39	38	const {
40	39	HTTP2_HEADER_AUTHORITY,
	40	+ HTTP2_HEADER_CONNECTION,
41	41	HTTP2_HEADER_METHOD,
42	42	HTTP2_HEADER_PATH,
43	43	HTTP2_HEADER_SCHEME,
@@ -95,7 +95,7 @@ function statusMessageWarn() {
95	95	}
96	96
97	97	function isConnectionHeaderAllowed(name, value) {
98		- return name !== constants.HTTP2_HEADER_CONNECTION ||
	98	+ return name !== HTTP2_HEADER_CONNECTION ||
99	99	value === 'trailers';
100	100	}
101	101

0 commit comments

Comments

0 (0)