FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: add constant to already destructured constants by dnalborczyk · Pull Request #28176 · nodejs/node · GitHub

/ node Public

http2: add constant to already destructured constants - #28176

Closed
dnalborczyk wants to merge 2 commits into
nodejs:masterfrom
dnalborczyk:destruct
ConversationCommits (2)ChecksFiles changed
Closed

http2: add constant to already destructured constants#28176
dnalborczyk wants to merge 2 commits into
nodejs:masterfrom
dnalborczyk:destruct

Conversation

dnalborczyk commented Jun 11, 2019

Copy link
Copy Markdown
Contributor

add constant to already destructured constants and while we're at it, destructure Readable and constants as well, remove binding.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jun 11, 2019
lpinca reviewed Jun 11, 2019
View reviewed changes
Comment thread lib/internal/http2/compat.js Outdated
Comment thread lib/internal/http2/compat.js
const Readable = Stream.Readable;
const binding = internalBinding('http2');
const constants = binding.constants;
const { Readable } = Stream;

lpinca Jun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
const { Readable } = Stream;
const { Readable } = require('stream');

dnalborczyk Jun 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thing is that Http2ServerResponse extends from Stream below, so we need a Stream reference as well. if we could use ES6 modules internally, I'd use a 'default', and a 'named import': import Stream, { Readable } from ....

Comment thread lib/internal/http2/compat.js
@@ -4,9 +4,8 @@ const { Object, ObjectPrototype, Reflect } = primordials;

const assert = require('internal/assert');
const Stream = require('stream');

lpinca Jun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
const Stream = require('stream');

BridgeAR commented Jul 5, 2019

Copy link
Copy Markdown
Member

I am not a huge fan of changes like these. They do not seem to bring much benefit but I won't block this either.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 5, 2019

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jul 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24339/

nodejs-github-bot commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24758/

nodejs-github-bot commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24769/

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

Landed in 3a9cb5c...b04de23

Trott closed this Jul 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
http2: add constant to already destructured constants
62c8c61 
PR-URL: nodejs#28176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
http2: destructure constants from require call
b04de23 
PR-URL: nodejs#28176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
http2: add constant to already destructured constants
d0d3149 
PR-URL: #28176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
http2: destructure constants from require call
fa82cbc 
PR-URL: #28176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR mentioned this pull request Aug 6, 2019
Merged
dnalborczyk deleted the destruct branch May 21, 2020 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca left review comments
jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL