Commit d384911
doc: remove "note that" from async_hooks.md
PR-URL: #28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 9ca7c86 commit d384911
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -111,7 +111,7 @@ const asyncHook = async_hooks.createHook({ | |||
| 111 | 111 | }); | |
| 112 | 112 | ``` | |
| 113 | 113 | ||
| 114 | - Note that the callbacks will be inherited via the prototype chain: | ||
| 114 | + The callbacks will be inherited via the prototype chain: | ||
| 115 | 115 | ||
| 116 | 116 | ```js | |
| 117 | 117 | class MyAsyncCallbacks { | |
@@ -439,7 +439,7 @@ added: v8.6.0 | |||
| 439 | 439 | Called when the `resolve` function passed to the `Promise` constructor is | |
| 440 | 440 | invoked (either directly or through other means of resolving a promise). | |
| 441 | 441 | ||
| 442 | - Note that `resolve()` does not do any observable synchronous work. | ||
| 442 | + `resolve()` does not do any observable synchronous work. | ||
| 443 | 443 | ||
| 444 | 444 | The `Promise` is not necessarily fulfilled or rejected at this point if the | |
| 445 | 445 | `Promise` was resolved by assuming the state of another `Promise`. | |
@@ -497,7 +497,7 @@ const server = net.createServer((conn) => { | |||
| 497 | 497 | }); | |
| 498 | 498 | ``` | |
| 499 | 499 | ||
| 500 | - Note that promise contexts may not get precise `executionAsyncIds` by default. | ||
| 500 | + Promise contexts may not get precise `executionAsyncIds` by default. | ||
| 501 | 501 | See the section on [promise execution tracking][]. | |
| 502 | 502 | ||
| 503 | 503 | #### async_hooks.triggerAsyncId() | |
@@ -520,7 +520,7 @@ const server = net.createServer((conn) => { | |||
| 520 | 520 | }); | |
| 521 | 521 | ``` | |
| 522 | 522 | ||
| 523 | - Note that promise contexts may not get valid `triggerAsyncId`s by default. See | ||
| 523 | + Promise contexts may not get valid `triggerAsyncId`s by default. See | ||
| 524 | 524 | the section on [promise execution tracking][]. | |
| 525 | 525 | ||
| 526 | 526 | ## Promise execution tracking | |
@@ -540,7 +540,7 @@ Promise.resolve(1729).then(() => { | |||
| 540 | 540 | ``` | |
| 541 | 541 | ||
| 542 | 542 | Observe that the `then()` callback claims to have executed in the context of the | |
| 543 | - outer scope even though there was an asynchronous hop involved. Also note that | ||
| 543 | + outer scope even though there was an asynchronous hop involved. Also, | ||
| 544 | 544 | the `triggerAsyncId` value is `0`, which means that we are missing context about | |
| 545 | 545 | the resource that caused (triggered) the `then()` callback to be executed. | |
| 546 | 546 | ||
0 commit comments