Commit d550de4
src: remove inspector main_thread_request_ field
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.
Refs: #26089
Refs: #26006
PR-URL: #26137
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent ee71952 commit d550de4
2 files changed
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -224,11 +224,6 @@ MainThreadInterface::MainThreadInterface(Agent* agent, uv_loop_t* loop, | |||
| 224 | 224 | v8::Platform* platform) | |
| 225 | 225 | : agent_(agent), isolate_(isolate), | |
| 226 | 226 | platform_(platform) { | |
| 227 | - main_thread_request_.reset(new AsyncAndInterface(uv_async_t(), this)); | ||
| 228 | - CHECK_EQ(0, uv_async_init(loop, &main_thread_request_->first, | ||
| 229 | - DispatchMessagesAsyncCallback)); | ||
| 230 | - // Inspector uv_async_t should not prevent main loop shutdown. | ||
| 231 | - uv_unref(reinterpret_cast<uv_handle_t*>(&main_thread_request_->first)); | ||
| 232 | 227 | } | |
| 233 | 228 | ||
| 234 | 229 | MainThreadInterface::~MainThreadInterface() { | |
@@ -253,7 +248,6 @@ void MainThreadInterface::Post(std::unique_ptr<Request> request) { | |||
| 253 | 248 | bool needs_notify = requests_.empty(); | |
| 254 | 249 | requests_.push_back(std::move(request)); | |
| 255 | 250 | if (needs_notify) { | |
| 256 | - CHECK_EQ(0, uv_async_send(&main_thread_request_->first)); | ||
| 257 | 251 | if (isolate_ != nullptr && platform_ != nullptr) { | |
| 258 | 252 | std::shared_ptr<v8::TaskRunner> taskrunner = | |
| 259 | 253 | platform_->GetForegroundTaskRunner(isolate_); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -105,7 +105,6 @@ class MainThreadInterface { | |||
| 105 | 105 | Agent* const agent_; | |
| 106 | 106 | v8::Isolate* const isolate_; | |
| 107 | 107 | v8::Platform* const platform_; | |
| 108 | - DeleteFnPtr<AsyncAndInterface, CloseAsync> main_thread_request_; | ||
| 109 | 108 | std::shared_ptr<MainThreadHandle> handle_; | |
| 110 | 109 | std::unordered_map<int, std::unique_ptr<Deletable>> managed_objects_; | |
| 111 | 110 | }; | |
0 commit comments