FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove inspector main_thread_request_ field by addaleax · Pull Request #26137 · nodejs/node · GitHub

/ node Public

src: remove inspector main_thread_request_ field - #26137

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:no-main-thread-request
ConversationCommits (1)ChecksFiles changed
Closed

src: remove inspector main_thread_request_ field#26137
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:no-main-thread-request

Conversation

addaleax commented Feb 15, 2019

Copy link
Copy Markdown
Member

This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.

Refs: #26089
Refs: #26006

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: remove inspector main_thread_request_ field
529274f 
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.

Refs: nodejs#26089
Refs: nodejs#26006
addaleax requested a review from eugeneo February 15, 2019 18:52

nodejs-github-bot commented Feb 15, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2624/pipeline

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 15, 2019
addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Feb 15, 2019
addaleax mentioned this pull request Feb 15, 2019
Closed
4 tasks

addaleax commented Feb 16, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20819/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 16, 2019

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
Member Author

Landed in c583245

addaleax closed this Feb 17, 2019
addaleax deleted the no-main-thread-request branch February 17, 2019 23:06
addaleax added a commit that referenced this pull request Feb 17, 2019
src: remove inspector main_thread_request_ field
c583245 
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.

Refs: #26089
Refs: #26006

PR-URL: #26137
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit that referenced this pull request Feb 18, 2019
src: remove inspector main_thread_request_ field
79276cc 
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.

Refs: #26089
Refs: #26006

PR-URL: #26137
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Feb 24, 2019
src: remove dead inspector code
6ec32dc 
This was overlooked in c583245.

Refs: nodejs#26137
addaleax mentioned this pull request Feb 24, 2019
Closed
2 tasks
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
src: remove inspector main_thread_request_ field
d550de4 
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.

Refs: #26089
Refs: #26006

PR-URL: #26137
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
b0b370c 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
30f0a3b 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes
+1 more reviewer
eugeneo eugeneo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL