FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove dead inspector code by addaleax · Pull Request #26295 · nodejs/node · GitHub

/ node Public

src: remove dead inspector code - #26295

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:inspector-dead-code
ConversationCommits (1)ChecksFiles changed
Closed

src: remove dead inspector code#26295
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:inspector-dead-code

Conversation

addaleax commented Feb 24, 2019

Copy link
Copy Markdown
Member

This was overlooked in c583245.

Refs: #26137

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Feb 24, 2019

Copy link
Copy Markdown
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Feb 24, 2019

addaleax commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21067/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 28, 2019

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21080/

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
Member Author

Landed in b0b370c

addaleax closed this Mar 1, 2019
addaleax deleted the inspector-dead-code branch March 1, 2019 20:48
addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
b0b370c 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
30f0a3b 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BridgeAR mentioned this pull request Mar 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL