Commit d7d22ea
committed
src: add comments for cares library init refcount
Ref: #14738
PR-URL: #14743
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b87fae9 commit d7d22ea
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -489,6 +489,8 @@ void ChannelWrap::Setup() { | |||
| 489 | 489 | ||
| 490 | 490 | int r; | |
| 491 | 491 | if (!library_inited_) { | |
| 492 | + // Multiple calls to ares_library_init() increase a reference counter, | ||
| 493 | + // so this is a no-op except for the first call to it. | ||
| 492 | 494 | r = ares_library_init(ARES_LIB_INIT_ALL); | |
| 493 | 495 | if (r != ARES_SUCCESS) | |
| 494 | 496 | return env()->ThrowError(ToErrorCodeString(r)); | |
@@ -516,8 +518,10 @@ void ChannelWrap::Setup() { | |||
| 516 | 518 | ||
| 517 | 519 | ||
| 518 | 520 | ChannelWrap::~ChannelWrap() { | |
| 519 | - if (library_inited_) | ||
| 521 | + if (library_inited_) { | ||
| 522 | + // This decreases the reference counter increased by ares_library_init(). | ||
| 520 | 523 | ares_library_cleanup(); | |
| 524 | + } | ||
| 521 | 525 | ||
| 522 | 526 | ares_destroy(channel_); | |
| 523 | 527 | CleanupTimer(); | |
0 commit comments