FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add comments for cares library init refcount by addaleax · Pull Request #14743 · nodejs/node · GitHub

/ node Public

src: add comments for cares library init refcount - #14743

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:cares-comments
ConversationCommits (1)ChecksFiles changed
Closed

src: add comments for cares library init refcount#14743
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:cares-comments

Conversation

addaleax commented Aug 10, 2017

Copy link
Copy Markdown
Member

Ref: #14738

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/cares_wrap

@XadillaX

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Aug 10, 2017
bnoordhuis approved these changes Aug 10, 2017
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. With the recent changes, can the refcount ever drop to zero now?

addaleax commented Aug 10, 2017

Copy link
Copy Markdown
Member Author

With the recent changes, can the refcount ever drop to zero now?

Not the way lib/dns.js currently works, no.

XadillaX approved these changes Aug 10, 2017
View reviewed changes

XadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

XadillaX commented Aug 11, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9613/

addaleax added a commit that referenced this pull request Aug 11, 2017
src: add comments for cares library init refcount
eb8f574 
Ref: #14738
PR-URL: #14743
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Aug 11, 2017

Copy link
Copy Markdown
Member Author

This doesn’t need to wait 48 hours, landed in eb8f574

addaleax closed this Aug 11, 2017
addaleax deleted the cares-comments branch August 11, 2017 19:35
addaleax added a commit that referenced this pull request Aug 12, 2017
src: add comments for cares library init refcount
d7d22ea 
Ref: #14738
PR-URL: #14743
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax mentioned this pull request Aug 13, 2017
Merged

MylesBorins commented Sep 19, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
+2 more reviewers
TimothyGu TimothyGu approved these changes
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL