Commit d8eb83c
build: compile bundled simdjson conditionally
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.
Resolves #52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 83e02dc commit d8eb83c
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -849,7 +849,6 @@ | |||
| 849 | 849 | 'dependencies': [ | |
| 850 | 850 | 'deps/googletest/googletest.gyp:gtest_prod', | |
| 851 | 851 | 'deps/histogram/histogram.gyp:histogram', | |
| 852 | - 'deps/simdjson/simdjson.gyp:simdjson', | ||
| 853 | 852 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 854 | 853 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 855 | 854 | 'node_js2c#host', | |
@@ -1171,7 +1170,6 @@ | |||
| 1171 | 1170 | 'deps/googletest/googletest.gyp:gtest', | |
| 1172 | 1171 | 'deps/googletest/googletest.gyp:gtest_main', | |
| 1173 | 1172 | 'deps/histogram/histogram.gyp:histogram', | |
| 1174 | - 'deps/simdjson/simdjson.gyp:simdjson', | ||
| 1175 | 1173 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 1176 | 1174 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1177 | 1175 | ], | |
@@ -1364,7 +1362,6 @@ | |||
| 1364 | 1362 | '<(node_lib_target_name)', | |
| 1365 | 1363 | 'deps/histogram/histogram.gyp:histogram', | |
| 1366 | 1364 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1367 | - 'deps/simdjson/simdjson.gyp:simdjson', | ||
| 1368 | 1365 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 1369 | 1366 | ], | |
| 1370 | 1367 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -216,6 +216,10 @@ | |||
| 216 | 216 | 'dependencies': [ 'deps/ada/ada.gyp:ada' ], | |
| 217 | 217 | }], | |
| 218 | 218 | ||
| 219 | + [ 'node_shared_simdjson=="false"', { | ||
| 220 | + 'dependencies': [ 'deps/simdjson/simdjson.gyp:simdjson' ], | ||
| 221 | + }], | ||
| 222 | + | ||
| 219 | 223 | [ 'node_shared_brotli=="false"', { | |
| 220 | 224 | 'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ], | |
| 221 | 225 | }], | |
0 commit comments