build: fix missing x64 arch suffix in binary tar name · nodejs/node@dc7a232 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit dc7a232

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

BethGriggs

committed

build: fix missing x64 arch suffix in binary tar name

PR-URL: #30877 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent be4fffe commit dc7a232
Copy full SHA for dc7a232

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Makefile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -842,6 +842,7 @@ endif
842	842	endif
843	843	endif
844	844	endif
	845	+ endif
845	846	ifeq ($(DESTCPU),x64)
846	847	ARCH=x64
847	848	else
@@ -871,7 +872,6 @@ endif
871	872	endif
872	873	endif
873	874	endif
874		- endif
875	875
876	876	# node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
877	877	# pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.

0 commit comments

Comments

0 (0)