FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix missing arch suffix in binary tar name by legendecas · Pull Request #30877 · nodejs/node · GitHub

/ node Public

build: fix missing arch suffix in binary tar name - #30877

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:build
ConversationCommits (1)ChecksFiles changed
Closed

build: fix missing arch suffix in binary tar name#30877
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:build

Conversation

legendecas commented Dec 10, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 10, 2019
legendecas changed the title build: fix missing x64 arch suffix in binary tar name build: fix missing arch suffix in binary tar name Dec 10, 2019

legendecas commented Dec 13, 2019

Copy link
Copy Markdown
Member Author

@nodejs/build wondering if this misaligned endif was made by intention or not, may I ask for reviews on the PR from build team forks?

richardlau approved these changes Dec 13, 2019
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch! I'm assuming the release jobs (I can't see them) have the ARCH environment variable set, which is why this wasn't spotted before or cause issues for the releases.

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 13, 2019

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27617/

richardlau commented Dec 13, 2019

Copy link
Copy Markdown
Member

cc @nodejs/build-files

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27634/

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27646/

Trott pushed a commit that referenced this pull request Dec 14, 2019
build: fix missing x64 arch suffix in binary tar name
1807c3e 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Dec 14, 2019

Copy link
Copy Markdown
Member

Landed in 1807c3e

Trott closed this Dec 14, 2019
legendecas deleted the build branch December 14, 2019 05:47
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
build: fix missing x64 arch suffix in binary tar name
60225c1 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Dec 17, 2019
Merged

rvagg commented Dec 20, 2019

Copy link
Copy Markdown
Member

👍

I've been very careful to make sure to be explicit with ARCH (and some others) on release machines which is why this probably hasn't been caught before.

targos pushed a commit that referenced this pull request Jan 14, 2020
build: fix missing x64 arch suffix in binary tar name
1811b1a 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
build: fix missing x64 arch suffix in binary tar name
dc7a232 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
richardlau richardlau approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL