Commit de125a5
crypto: avoid double free
Coverity scan reported a free after use and I think its
right. Tweak to avoid double free.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40380
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 7b74638 commit de125a5
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -550,9 +550,12 @@ struct EnginePointer { | |||
| 550 | 550 | ||
| 551 | 551 | inline void reset(ENGINE* engine_ = nullptr, bool finish_on_exit_ = false) { | |
| 552 | 552 | if (engine != nullptr) { | |
| 553 | - if (finish_on_exit) | ||
| 554 | - ENGINE_finish(engine); | ||
| 555 | - ENGINE_free(engine); | ||
| 553 | + if (finish_on_exit) { | ||
| 554 | + // This also does the equivalent of ENGINE_free. | ||
| 555 | + CHECK_EQ(ENGINE_finish(engine), 1); | ||
| 556 | + } else { | ||
| 557 | + CHECK_EQ(ENGINE_free(engine), 1); | ||
| 558 | + } | ||
| 556 | 559 | } | |
| 557 | 560 | engine = engine_; | |
| 558 | 561 | finish_on_exit = finish_on_exit_; | |
0 commit comments