crypto: avoid double free - #40380
Closed
mhdawson wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com>
jasnell
approved these changes
Oct 9, 2021
lpinca
approved these changes
Oct 9, 2021
lpinca
reviewed
Oct 9, 2021
Comment thread
src/crypto/crypto_util.h
Outdated
RaisinTen
reviewed
Oct 11, 2021
Comment thread
src/crypto/crypto_util.h
Outdated
RaisinTen
reviewed
Oct 11, 2021
Comment thread
src/crypto/crypto_util.h
Outdated
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
JungMinu
approved these changes
Oct 13, 2021
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RaisinTen
approved these changes
Oct 14, 2021
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM (needs a squash to fix the commit message linter error)
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 15, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
25 tasks
Copy link
Copy Markdown
Member
Author
|
Landing manually should auto-fix the CI job complaint about the commit comment. Landing. |
Sorry, something went wrong.
mhdawson
added a commit
that referenced
this pull request
Oct 19, 2021
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
27 tasks
targos
pushed a commit
that referenced
this pull request
Oct 20, 2021
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Oct 21, 2021
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverity scan reported a free after use and I think its
right. Tweak to avoid double free.
Signed-off-by: Michael Dawson mdawson@devrus.com