Commit e3097b7
test: test isFullWidthCodePoint with invalid input
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.
PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent f0b0fc4 commit e3097b7
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -304,6 +304,11 @@ function isWarned(emitter) { | |||
| 304 | 304 | rli.close(); | |
| 305 | 305 | } | |
| 306 | 306 | ||
| 307 | + // isFullWidthCodePoint() should return false for non-numeric values | ||
| 308 | + [true, false, null, undefined, {}, [], 'あ'].forEach((v) => { | ||
| 309 | + assert.strictEqual(readline.isFullWidthCodePoint('あ'), false); | ||
| 310 | + }); | ||
| 311 | + | ||
| 307 | 312 | // wide characters should be treated as two columns. | |
| 308 | 313 | assert.equal(readline.isFullWidthCodePoint('a'.charCodeAt(0)), false); | |
| 309 | 314 | assert.equal(readline.isFullWidthCodePoint('あ'.charCodeAt(0)), true); | |
0 commit comments