FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: test isFullWidthCodePoint with invalid input by Trott · Pull Request #7422 · nodejs/node · GitHub

/ node Public

test: test isFullWidthCodePoint with invalid input - #7422

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:widefalse
ConversationCommits (2)ChecksFiles changed
Closed

test: test isFullWidthCodePoint with invalid input#7422
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:widefalse

Conversation

Trott commented Jun 25, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test readline

Description of change

Code coverage information shows that we are only testing the happy path
for the internal readlind isFullWidthCodePoint() function. Test it
with invalid input.

Trott added readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests. labels Jun 25, 2016

addaleax commented Jun 25, 2016

Copy link
Copy Markdown
Member

There’s a typo (readlind) in the commit message, but other than that LGTM.

Trott commented Jun 25, 2016

Copy link
Copy Markdown
Member Author

Typo fixed, thanks!

mscdex commented Jun 25, 2016

Copy link
Copy Markdown
Contributor

LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/3084/

bnoordhuis reviewed Jun 27, 2016
View reviewed changes
Comment thread test/parallel/test-readline-interface.js Outdated

bnoordhuis Jun 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps you can extend this to [true, false, null, undefined, {}, [], 'あ'].forEach((v) => {?

bnoordhuis commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM with a suggestion.

jasnell commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM with @bnoordhuis' suggestion

test: test isFullWidthCodePoint with invalid input
ae0ef11 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

Trott commented Jun 28, 2016

Copy link
Copy Markdown
Member Author

Added the additional primitives to check per @bnoordhuis.

New CI: https://ci.nodejs.org/job/node-test-pull-request/3101/

Trott commented Jun 28, 2016

Copy link
Copy Markdown
Member Author

One Raspberry Pi build on CI didn't complete, but otherwise, CI looks good.

bnoordhuis commented Jun 28, 2016

Copy link
Copy Markdown
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 29, 2016
test: test isFullWidthCodePoint with invalid input
bbf3838 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: nodejs#7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Jun 29, 2016

Copy link
Copy Markdown
Member Author

Landed in bbf3838

Trott closed this Jun 29, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
test: test isFullWidthCodePoint with invalid input
365f520 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed

MylesBorins commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

appears to be using api's not in v4. Please correct me if wrong

cjihrig commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

isFullWidthCodePoint() is in v4. It was in the public readline module before being made internal.

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: test isFullWidthCodePoint with invalid input
8a20c14 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

thanks for the heads up @cjihrig backported in 8a20c14

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: test isFullWidthCodePoint with invalid input
c030713 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: test isFullWidthCodePoint with invalid input
c3c26a2 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: test isFullWidthCodePoint with invalid input
8427ffc 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: test isFullWidthCodePoint with invalid input
460aba1 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: test isFullWidthCodePoint with invalid input
42a6d01 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: test isFullWidthCodePoint with invalid input
e3097b7 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.

PR-URL: #7422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott deleted the widefalse branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL