FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: move util.isBuffer to eol · nodejs/node@e32b0c1 · GitHub

/ node Public

Commit e32b0c1

Browse files
marco-ippolito
authored and
nodejs-github-bot
committed
util: move util.isBuffer to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent be528ab commit e32b0c1

4 files changed

Lines changed: 5 additions & 38 deletions

File tree

‎doc/api/deprecations.md‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,6 +1023,9 @@ The `util.isBoolean()` API has been removed. Please use
10231023

10241024
<!-- YAML
10251025
changes:
1026+
- version: REPLACEME
1027+
pr-url: https://github.com/nodejs/node/pull/52744
1028+
description: End-of-Life deprecation.
10261029
- version: v22.0.0
10271030
pr-url: https://github.com/nodejs/node/pull/50488
10281031
description: Runtime deprecation.
@@ -1038,9 +1041,9 @@ changes:
10381041
description: Documentation-only deprecation.
10391042
-->
10401043

1041-
Type: Runtime
1044+
Type: End-of-Life
10421045

1043-
The [`util.isBuffer()`][] API is deprecated. Please use
1046+
The `util.isBuffer()` API has been removed. Please use
10441047
[`Buffer.isBuffer()`][] instead.
10451048

10461049
### DEP0047: `util.isDate()`
@@ -3779,8 +3782,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
37793782
[`util.inspect()`]: util.md#utilinspectobject-options
37803783
[`util.inspect.custom`]: util.md#utilinspectcustom
37813784
[`util.isArray()`]: util.md#utilisarrayobject
3782-
[`util.isBuffer()`]: util.md#utilisbufferobject
3783-
[`util.isDate()`]: util.md#utilisdateobject
37843785
[`util.isError()`]: util.md#utiliserrorobject
37853786
[`util.isFunction()`]: util.md#utilisfunctionobject
37863787
[`util.isNull()`]: util.md#utilisnullobject

‎doc/api/util.md‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2950,31 +2950,6 @@ util.isArray({});
29502950
// Returns: false
29512951
```
29522952
2953-
### `util.isBuffer(object)`
2954-
2955-
<!-- YAML
2956-
added: v0.11.5
2957-
deprecated: v4.0.0
2958-
-->
2959-
2960-
> Stability: 0 - Deprecated: Use [`Buffer.isBuffer()`][] instead.
2961-
2962-
* `object` {any}
2963-
* Returns: {boolean}
2964-
2965-
Returns `true` if the given `object` is a `Buffer`. Otherwise, returns `false`.
2966-
2967-
```js
2968-
const util = require('node:util');
2969-
2970-
util.isBuffer({ length: 0 });
2971-
// Returns: false
2972-
util.isBuffer([]);
2973-
// Returns: false
2974-
util.isBuffer(Buffer.from('hello world'));
2975-
// Returns: true
2976-
```
2977-
29782953
### `util.isDate(object)`
29792954
29802955
<!-- YAML
@@ -3355,7 +3330,6 @@ util.log('Timestamped message.');
33553330
[`Array.isArray()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray
33563331
[`ArrayBuffer.isView()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView
33573332
[`ArrayBuffer`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer
3358-
[`Buffer.isBuffer()`]: buffer.md#static-method-bufferisbufferobj
33593333
[`DataView`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView
33603334
[`Date`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
33613335
[`Error`]: errors.md#class-error

‎lib/util.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ const {
7070
validateString,
7171
validateOneOf,
7272
} = require('internal/validators');
73-
const { isBuffer } = require('buffer').Buffer;
7473
const types = require('internal/util/types');
7574
const binding = internalBinding('util');
7675

@@ -410,9 +409,6 @@ module.exports = {
410409
isArray: deprecate(ArrayIsArray,
411410
'The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.',
412411
'DEP0044'),
413-
isBuffer: deprecate(isBuffer,
414-
'The `util.isBuffer` API is deprecated. Please use `Buffer.isBuffer()` instead.',
415-
'DEP0046'),
416412
isDeepStrictEqual(a, b) {
417413
if (internalDeepEqual === undefined) {
418414
internalDeepEqual = require('internal/util/comparisons')

‎test/parallel/test-util.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ assert.strictEqual(util.isPrimitive(Infinity), true);
9898
assert.strictEqual(util.isPrimitive(NaN), true);
9999
assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
100100

101-
// isBuffer
102-
assert.strictEqual(util.isBuffer('foo'), false);
103-
assert.strictEqual(util.isBuffer(Buffer.from('foo')), true);
104-
105101
assert.strictEqual(util.isNull(null), true);
106102
assert.strictEqual(util.isNull(undefined), false);
107103
assert.strictEqual(util.isNull(), false);

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL