test: Remove unnecessary asserion messages in test-crypto-hash.js · nodejs/node@e4c320e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e4c320e

Browse filesBrowse the repository at this point in the historyBrowse files

pgrzesik

authored and

MylesBorins

committed

test: Remove unnecessary asserion messages in test-crypto-hash.js

This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent 3e6858e commit e4c320e
Copy full SHA for e4c320e

1 file changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-crypto-hash.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-crypto-hash.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-crypto-hash.js

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -82,15 +82,15 @@ assert.deepStrictEqual(
82	82	);
83	83
84	84	// stream interface should produce the same result.
85		- assert.deepStrictEqual(a5, a3, 'stream interface is consistent');
86		- assert.deepStrictEqual(a6, a3, 'stream interface is consistent');
87		- assert.notStrictEqual(a7, undefined, 'no data should return data');
88		- assert.notStrictEqual(a8, undefined, 'empty string should generate data');
	85	+ assert.deepStrictEqual(a5, a3);
	86	+ assert.deepStrictEqual(a6, a3);
	87	+ assert.notStrictEqual(a7, undefined);
	88	+ assert.notStrictEqual(a8, undefined);
89	89
90	90	// Test multiple updates to same hash
91	91	const h1 = crypto.createHash('sha1').update('Test123').digest('hex');
92	92	const h2 = crypto.createHash('sha1').update('Test').update('123').digest('hex');
93		- assert.strictEqual(h1, h2, 'multipled updates');
	93	+ assert.strictEqual(h1, h2);
94	94
95	95	// Test hashing for binary files
96	96	const fn = fixtures.path('sample.png');

0 commit comments

Comments

0 (0)