test: Remove unnecessary asserion messages in test-crypto-hash.js - #18984
Closed
pgrzesik wants to merge 1 commit into
Closed
test: Remove unnecessary asserion messages in test-crypto-hash.js#18984pgrzesik wants to merge 1 commit into
pgrzesik wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Feb 26, 2018
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is an improvement but it would also be good to remove the message argument entirely.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hey @jasnell, thanks for response, I don't have strong opinion on which approach is better - do you think that removing message args is a better way to improve those assertions ? btw - I'd be more than happy to help on similar(or a bit more advanced) issues |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Mar 1, 2018
BridgeAR
reviewed
Mar 1, 2018
Comment thread
test/parallel/test-crypto-hash.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
a7 is always undefined in this case. So it is the same as having a static message. The same applies for the test below. I think it is best to just remove the message all along. Probably in all cases here.
Sorry, something went wrong.
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors.
pgrzesik
force-pushed
the
fix/improve-assertions-in-test-crypto-hash
branch
from
f9a906e to
5af816a
Compare
March 3, 2018 20:43
BridgeAR
approved these changes
Mar 3, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tniessen
approved these changes
Mar 4, 2018
BridgeAR
pushed a commit
that referenced
this pull request
Mar 11, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Copy link
Copy Markdown
Member
|
@pgrzesik congratulations to your first commit to Node.js 🎉 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: nodejs#18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: nodejs#18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. Backport-PR-URL: #22380 PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves asserion messages in parallel/test-crypto-hash.js.
Instead of just simple string literal, messages are changed to also
include values used in assertion, which should improve debugging
in case of errors.
Checklist
Affected core subsystem(s)
None