Commit e6bbc50
committed
doc: improve the workflow to test release binaries
PR-URL: #45004
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 43677e5 commit e6bbc50
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -603,13 +603,14 @@ the build before moving forward. Use the following list as a baseline: | |||
| 603 | 603 | must be in the expected updated version) | |
| 604 | 604 | * npm version (check it matches what we expect) | |
| 605 | 605 | * Run the test suite against the built binaries (optional) | |
| 606 | + * Remember to use the proposal branch | ||
| 607 | + * Run `make build-addons` before running the tests | ||
| 608 | + * Remove `config.gypi` file | ||
| 606 | 609 | ||
| 607 | 610 | ```console | |
| 608 | 611 | ./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node | |
| 609 | 612 | ``` | |
| 610 | 613 | ||
| 611 | - <sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup> | ||
| 612 | - | ||
| 613 | 614 | ### 11. Tag and sign the release commit | |
| 614 | 615 | ||
| 615 | 616 | Once you have produced builds that you're happy with, create a new tag. By | |
0 commit comments