doc: improve the workflow to test release binaries - #45004
Merged
nodejs-github-bot merged 1 commit intoOct 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
reviewed
Oct 14, 2022
Comment thread
doc/contributing/releases.md
Outdated
RafaelGSS
force-pushed
the
doc/improve-binary-test
branch
from
9d715ce to
e0588a6
Compare
October 14, 2022 19:33
aduh95
reviewed
Oct 14, 2022
Comment thread
doc/contributing/releases.md
Outdated
aduh95
reviewed
Oct 14, 2022
Comment thread
doc/contributing/releases.md
Outdated
richardlau
reviewed
Oct 14, 2022
Comment thread
doc/contributing/releases.md
Outdated
RafaelGSS
force-pushed
the
doc/improve-binary-test
branch
from
e0588a6 to
8d6ab7d
Compare
October 15, 2022 12:34
RafaelGSS
force-pushed
the
doc/improve-binary-test
branch
from
8d6ab7d to
e72b5ec
Compare
October 15, 2022 15:29
RafaelGSS
force-pushed
the
doc/improve-binary-test
branch
from
e72b5ec to
d5a6619
Compare
October 15, 2022 15:29
aduh95
reviewed
Oct 15, 2022
Comment thread
doc/contributing/releases.md
aduh95
approved these changes
Oct 15, 2022
Trott
approved these changes
Oct 15, 2022
lpinca
approved these changes
Oct 15, 2022
jasnell
approved these changes
Oct 15, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45004 ✔ Done loading data for nodejs/node/pull/45004 ----------------------------------- PR info ------------------------------------ Title doc: improve the workflow to test release binaries (#45004) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc/improve-binary-test -> nodejs:main Labels doc, author ready Commits 1 - doc: improve the workflow to test release binaries Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/45004 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45004 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Oct 2022 18:12:45 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143203862 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143215322 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143221315 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143226142 ✖ This PR needs to wait 21 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3257083627 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Sorry, something went wrong.
RafaelGSS
added a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
added a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this workflow we have a better test report.
I'm using it to test the new major (v19) and it only fails 2 tests (the ones I mentioned in the doc). Those failures are expected due to the test itself trusting in some variables not present in the final binary.