test: os, replace custom flatten method with built-in Array.flat · nodejs/node@eb91932 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit eb91932

Browse filesBrowse the repository at this point in the historyBrowse files

waelsy123

authored and

richardlau

committed

test: os, replace custom flatten method with built-in Array.flat

PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 826ae9b commit eb91932
Copy full SHA for eb91932

1 file changed

+2-5Lines changed: 2 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-os.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-os.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-os.js

+2-5Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -39,10 +39,6 @@ const is = {
39	39	}
40	40	};
41	41
42		- const flatten = (arr) =>
43		- arr.reduce((acc, c) =>
44		- acc.concat(Array.isArray(c) ? flatten(c) : c), []);
45		-
46	42	process.env.TMPDIR = '/tmpdir';
47	43	process.env.TMP = '/tmp';
48	44	process.env.TEMP = '/temp';
@@ -174,7 +170,8 @@ const netmaskToCIDRSuffixMap = new Map(Object.entries({
174	170	'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff': 128
175	171	}));
176	172
177		- flatten(Object.values(interfaces))
	173	+ Object.values(interfaces)
	174	+ .flat(Infinity)
178	175	.map((v) => ({ v, mask: netmaskToCIDRSuffixMap.get(v.netmask) }))
179	176	.forEach(({ v, mask }) => {
180	177	assert.ok('cidr' in v, `"cidr" prop not found in ${inspect(v)}`);

0 commit comments

Comments

0 (0)