test: os, replace custom flatten method with built-in Array.flat - #38770
Closed
waelsy123 wants to merge 3 commits into
Closed
test: os, replace custom flatten method with built-in Array.flat#38770waelsy123 wants to merge 3 commits into
waelsy123 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
test/parallel/test-os.js
Outdated
VoltrexKeyva
approved these changes
May 22, 2021
RaisinTen
approved these changes
May 23, 2021
RaisinTen
reviewed
May 23, 2021
Comment thread
test/parallel/test-os.js
Outdated
jasnell
approved these changes
May 23, 2021
Co-authored-by: Darshan Sen <raisinten@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to improve the test coverage code (test-os.js) as it's uses untested custom function (flatten) to use built-in method Array.flat()