Commit f086354
errors: alter ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error..
PR-URL: #19958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 3c1ad38 commit f086354
2 files changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -826,10 +826,8 @@ E('ERR_HTTP2_PAYLOAD_FORBIDDEN', | |||
| 826 | 826 | 'Responses with %s status must not have a payload', Error); | |
| 827 | 827 | E('ERR_HTTP2_PING_CANCEL', 'HTTP2 ping cancelled', Error); | |
| 828 | 828 | E('ERR_HTTP2_PING_LENGTH', 'HTTP2 ping payload must be 8 bytes', RangeError); | |
| 829 | - | ||
| 830 | - // This should probably be a `TypeError`. | ||
| 831 | 829 | E('ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED', | |
| 832 | - 'Cannot set HTTP/2 pseudo-headers', Error); | ||
| 830 | + 'Cannot set HTTP/2 pseudo-headers', TypeError); | ||
| 833 | 831 | E('ERR_HTTP2_PUSH_DISABLED', 'HTTP/2 client has disabled push streams', Error); | |
| 834 | 832 | E('ERR_HTTP2_SEND_FILE', 'Directories cannot be sent', Error); | |
| 835 | 833 | E('ERR_HTTP2_SEND_FILE_NOSEEK', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -63,7 +63,7 @@ server.listen(0, common.mustCall(function() { | |||
| 63 | 63 | () => response.setHeader(header, 'foobar'), | |
| 64 | 64 | { | |
| 65 | 65 | code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED', | |
| 66 | - type: Error, | ||
| 66 | + type: TypeError, | ||
| 67 | 67 | message: 'Cannot set HTTP/2 pseudo-headers' | |
| 68 | 68 | }) | |
| 69 | 69 | ); | |
0 commit comments