FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors: alter ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED by davidmarkclements · Pull Request #19958 · nodejs/node · GitHub

/ node Public

errors: alter ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED - #19958

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:errors-patch4
Closed

errors: alter ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED#19958
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:errors-patch4

Conversation

davidmarkclements commented Apr 11, 2018
edited
Loading

Copy link
Copy Markdown
Member

changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 11, 2018

hiroppy commented Apr 11, 2018

Copy link
Copy Markdown
Member

vsemozhetbyt added the http2 Issues or PRs related to the http2 subsystem. label Apr 12, 2018

Copy link
Copy Markdown
Contributor

Additionally corrects the grammar of the error message.

Seems obsolete (in the PR description and commit message)?

changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error..

Copy link
Copy Markdown
Member Author

@vsemozhetbyt copy paste error on my part - removed from commit message

jasnell pushed a commit that referenced this pull request Apr 14, 2018
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error..

PR-URL: #19958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

jasnell commented Apr 14, 2018

Copy link
Copy Markdown
Member

Landed in cc7bef9

jasnell closed this Apr 14, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error..

PR-URL: #19958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED
from Error to TypeError as a more accurate representation
of the error..

PR-URL: nodejs#19958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax mentioned this pull request Oct 20, 2018
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL