Commit f8a33ab
deps: V8: workaround for MSVC 14.20 optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 0a5ff4c commit f8a33ab
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.10', | ||
| 41 | + 'v8_embedder_string': '-node.11', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -297,6 +297,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index, | |||
| 297 | 297 | ||
| 298 | 298 | } // namespace | |
| 299 | 299 | ||
| 300 | + #if _MSC_VER == 1920 | ||
| 301 | + #pragma optimize( "", off ) | ||
| 302 | + #endif | ||
| 303 | + | ||
| 300 | 304 | // static | |
| 301 | 305 | void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) { | |
| 302 | 306 | Builtins* builtins = isolate->builtins(); | |
@@ -380,5 +384,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) { | |||
| 380 | 384 | builtins->MarkInitialized(); | |
| 381 | 385 | } | |
| 382 | 386 | ||
| 387 | + #if _MSC_VER == 1920 | ||
| 388 | + #pragma optimize( "", on ) | ||
| 389 | + #endif | ||
| 390 | + | ||
| 391 | + | ||
| 383 | 392 | } // namespace internal | |
| 384 | 393 | } // namespace v8 | |
0 commit comments