benchmark: simplify http benchmarker regular expression · nodejs/node@fa84353 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fa84353

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

benchmark: simplify http benchmarker regular expression

A non-capturing group inside a capturing group has no effect. Simplify the regular expression. PR-URL: #38206 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

1 parent 07353e9 commit fa84353
Copy full SHA for fa84353

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark
  • _http-benchmarkers.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/_http-benchmarkers.js‎

Copy file name to clipboardExpand all lines: benchmark/_http-benchmarkers.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -173,7 +173,7 @@ class H2LoadBenchmarker {
173	173	}
174	174
175	175	processResults(output) {
176		- const rex = /(\d+(?:\.\d+)) req\/s/;
	176	+ const rex = /(\d+\.\d+) req\/s/;
177	177	return rex.exec(output)[1];
178	178	}
179	179	}

0 commit comments

Comments

0 (0)