benchmark: simplify http benchmarker regular expression - #38206
Merged
Trott merged 1 commit intoJan 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Apr 12, 2021
Comment thread
benchmark/_http-benchmarkers.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Maybe the original intent was to handle integer values? I don't know if that's necessary, please disregard if we know that doesn't happen.
Suggested change
| const rex = /(\d+\.\d+) req\/s/; | |
| const rex = /(\d+(?:\.\d+)?) req\/s/; |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think it shouldn't work with integers. The h2load output is something like "finished in 233.18s, 0.43 req/s, 105B/s" his docs
Sorry, something went wrong.
lpinca
approved these changes
Apr 14, 2021
rickyes
approved these changes
Dec 15, 2021
A non-capturing group inside a capturing group has no effect. Simplify the regular expression. PR-URL: nodejs#38206 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
A non-capturing group inside a capturing group has no effect. Simplify the regular expression. PR-URL: #38206 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
A non-capturing group inside a capturing group has no effect. Simplify the regular expression. PR-URL: #38206 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-capturing group inside a capturing group has no effect. Simplify
the regular expression.