v16.14.0 proposal - #41804
Merged
danielleadams merged 385 commits intoFeb 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR-URL: #40987 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The API is still experimental, but the warning isn't necessary any longer Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40971 Refs: #40950 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Robert Nagy <ronagy@icloud.com>
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: #41011 PR-URL: #41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40899 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: whatwg/dom#1032 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40899 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #41027 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #41027 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
While inspecting errors, always visualize the cause. That property is non-enumerable by default while being useful in general for debugging. Duplicated stack frames are hidden. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41002 Fixes: #40859 Fixes: #38725 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This addresses a comment by loading the EOL from the constants file. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41004 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #40516 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Based on existing tests and code comments, url.parse() is expected to treat any URL containing user@host as having a hostname. However, it turns out this behavior relies on the URL having a hash which is surprising, to put it mildly. Detect the host even without the hash. PR-URL: #41031 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #41036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
PR-URL: #41036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This adds the `numericSeparator` option to util.inspect. Using it separates numbers by thousands adding the underscore accordingly. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs/abi-stable-node#252 I've been through the Node-api methods and I believe this is the last places where optional parameters were not documented. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41021 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #41035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
In example of implementing a writable stream with extending on Writable add explicit declaration of 'fd' (file descriptor) variable with null value. It will make this example more similar to readable stream's one. And will make it easier to figure out in topic. PR-URL: #40704 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Enable all recommended JSDoc linting rules and disable the ones we don't (yet?) meet. They can be enabled one by one by removing the lines that turn them off. This requires adding --max-warnings to the ESLint invocations in Makefile and vcbuild.bat because the preset enables the recommended rules as warnings and not errors. PR-URL: #41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #41060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Adds experimental implementations of the yield and wait APIs being explored at https://github.com/WICG/scheduling-apis. When I asked the WHATWG folks about the possibility of standardizing the [awaitable versions of setTimeout/setImmediate](whatwg/html#7340) that we have implemented in `timers/promises`, they pointed at the work in progress scheduling APIs draft as they direction they'll be going. While there is definitely a few thing in that draft that have questionable utility to Node.js, the yield and wait APIs map cleanly to the setImmediate and setTimeout we already have. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40909 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
29 tasks
Copy link
Copy Markdown
Contributor
Author
|
Running CITGM one more time because it looked like some tests didn't start: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2845/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Perhaps it was missed, but #41396 looks to be a good candidate for inclusion in this release as well. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
we can pull it into v16.x-staging for the next release, but I don't want to pull it into the release because we'd have to run CI again. |
Sorry, something went wrong.
BethGriggs
previously requested changes
Feb 7, 2022
Comment thread
doc/api/fs.md
Outdated
PR-URL: #41396 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Notable changes:
Importing JSON modules now requires experimental import assertions
syntax
This release adds experimental support for the import assertions stage 3
proposal.
To keep Node.js ESM implementation as compatible as possible with the
HTML spec, import assertions are now required to import JSON modules
(still behind the `--experimental-json-modules` CLI flag):
```mjs
import info from './package.json' assert { type: 'json' };
```
Or use dynamic import:
```mjs
const info = await import('./package.json', {
assert: { type: 'json' }
});
```
Contributed by Antoine du Hamel and Geoffrey Booth #40250
Other notable changes:
* async_hooks:
* (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760
* child_process:
* (SEMVER-MINOR) add support for URL to `cp.fork` (Antoine du Hamel) #41225
* doc:
* add @Mesteery to collaborators (Mestery) #41543
* add @bnb as a collaborator (Tierney Cyren) #41100
* esm:
* (SEMVER-MINOR) graduate capturerejections to supported (James M Snell) #41267
* (SEMVER-MINOR) add EventEmitterAsyncResource to core (James M Snell) #41246
* events:
* (SEMVER-MINOR) propagate weak option for kNewListener (James M Snell) #40899
* fs:
* (SEMVER-MINOR) accept URL as argument for `fs.rm` and `fs.rmSync` (Antoine du Hamel) #41132
* lib:
* (SEMVER-MINOR) make AbortSignal cloneable/transferable (James M Snell) #41050
* (SEMVER-MINOR) add AbortSignal.timeout (James M Snell) #40899
* (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807
* (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
* (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
* loader:
* (SEMVER-MINOR) return package format from defaultResolve if known (Gabriel Bota) #40980
* perf_hooks:
* (SEMVER-MINOR) multiple fixes for Histogram (James M Snell) #41153
* process:
* (SEMVER-MINOR) add `getActiveResourcesInfo()` (Darshan Sen) #40813
* src:
* (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809
* (SEMVER-MINOR) add flags for controlling process behavior (Cheng Zhao) #40339
* stream:
* (SEMVER-MINOR) add filter method to readable (Benjamin Gruenbaum) #41354
* (SEMVER-MINOR) add isReadable helper (Robert Nagy) #41199
* (SEMVER-MINOR) add map method to Readable (Benjamin Gruenbaum) #40815
* deprecate thenable support (Antoine du Hamel) #40860
* util:
* (SEMVER-MINOR) pass through the inspect function to custom inspect functions (Ruben Bridgewater) #41019
* (SEMVER-MINOR) add numericSeparator to util.inspect (Ruben Bridgewater) #41003
* (SEMVER-MINOR) always visualize cause property in errors during inspection (Ruben Bridgewater) #41002
* timers:
* (SEMVER-MINOR) add experimental scheduler api (James M Snell) #40909
* v8:
* (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283
PR-URL: #41804
danielleadams
force-pushed
the
v16.14.0-proposal
branch
from
7b99665 to
418ff70
Compare
February 7, 2022 20:27
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@BethGriggs fixed and pulled in #41396 |
Sorry, something went wrong.
22 tasks
tniessen
approved these changes
Feb 8, 2022
Copy link
Copy Markdown
Contributor
Author
|
Release builds: https://ci-release.nodejs.org/job/iojs+release/8244/. however, it looks like builds failed to upload the binaries after successful builds (not sure if it's related to the last couple nightlies hanging). cc @nodejs/build Is anyone able to assist? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
The hanging builds turned out to be an offline release machine that the builds were waiting to schedule onto and has been fixed by rebooting the offender nodejs/build#2863. I've opened nodejs/build#2864 for the upload failures. The later nightly builds succeeded in uploading binaries so hopefully this was a one off. The upload failures may have been related to a planned droplet migration, although the expected time window of the migration was later than the when the broken pipes causing the upload failures occurred. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Release builds: https://ci-release.nodejs.org/job/iojs+release/8247/, pending osx11-release-pkg |
Sorry, something went wrong.
danielleadams
added a commit
that referenced
this pull request
Feb 8, 2022
Notable changes:
Importing JSON modules now requires experimental import assertions
syntax
This release adds experimental support for the import assertions stage 3
proposal.
To keep Node.js ESM implementation as compatible as possible with the
HTML spec, import assertions are now required to import JSON modules
(still behind the `--experimental-json-modules` CLI flag):
```mjs
import info from './package.json' assert { type: 'json' };
```
Or use dynamic import:
```mjs
const info = await import('./package.json', {
assert: { type: 'json' }
});
```
Contributed by Antoine du Hamel and Geoffrey Booth #40250
Other notable changes:
* async_hooks:
* (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760
* child_process:
* (SEMVER-MINOR) add support for URL to `cp.fork` (Antoine du Hamel) #41225
* doc:
* add @Mesteery to collaborators (Mestery) #41543
* add @bnb as a collaborator (Tierney Cyren) #41100
* esm:
* (SEMVER-MINOR) graduate capturerejections to supported (James M Snell) #41267
* (SEMVER-MINOR) add EventEmitterAsyncResource to core (James M Snell) #41246
* events:
* (SEMVER-MINOR) propagate weak option for kNewListener (James M Snell) #40899
* fs:
* (SEMVER-MINOR) accept URL as argument for `fs.rm` and `fs.rmSync` (Antoine du Hamel) #41132
* lib:
* (SEMVER-MINOR) make AbortSignal cloneable/transferable (James M Snell) #41050
* (SEMVER-MINOR) add AbortSignal.timeout (James M Snell) #40899
* (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807
* (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
* (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
* loader:
* (SEMVER-MINOR) return package format from defaultResolve if known (Gabriel Bota) #40980
* perf_hooks:
* (SEMVER-MINOR) multiple fixes for Histogram (James M Snell) #41153
* process:
* (SEMVER-MINOR) add `getActiveResourcesInfo()` (Darshan Sen) #40813
* src:
* (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809
* (SEMVER-MINOR) add flags for controlling process behavior (Cheng Zhao) #40339
* stream:
* (SEMVER-MINOR) add filter method to readable (Benjamin Gruenbaum) #41354
* (SEMVER-MINOR) add isReadable helper (Robert Nagy) #41199
* (SEMVER-MINOR) add map method to Readable (Benjamin Gruenbaum) #40815
* deprecate thenable support (Antoine du Hamel) #40860
* util:
* (SEMVER-MINOR) pass through the inspect function to custom inspect functions (Ruben Bridgewater) #41019
* (SEMVER-MINOR) add numericSeparator to util.inspect (Ruben Bridgewater) #41003
* (SEMVER-MINOR) always visualize cause property in errors during inspection (Ruben Bridgewater) #41002
* timers:
* (SEMVER-MINOR) add experimental scheduler api (James M Snell) #40909
* v8:
* (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283
PR-URL: #41804
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 8, 2022
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 8, 2022
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 8, 2022
This was referenced Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-02-08, Version 16.14.0 'Gallium' (LTS), @danielleadams
Notable changes
Importing JSON modules now requires experimental import assertions syntax
This release adds experimental support for the import assertions stage 3 proposal.
To keep Node.js ESM implementation as compatible as possible with the HTML spec, import assertions are now required to import JSON modules (still behind the --experimental-json-modules CLI flag):
Or use dynamic import:
Contributed by Antoine du Hamel and Geoffrey Booth #40250
Other notable changes
Commits