FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-crypto-keygen flaky on windows by mhdawson · Pull Request #41207 · nodejs/node · GitHub

/ node Public

test: mark test-crypto-keygen flaky on windows - #41207

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:slow-windows
ConversationCommits (2)ChecksFiles changed
Closed

test: mark test-crypto-keygen flaky on windows#41207
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:slow-windows

Conversation

mhdawson commented Dec 16, 2021

Copy link
Copy Markdown
Member

Refs: #41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson mdawson@devrus.com

test: mark test-crypto-keygen slow on windows
e48d755 
Refs: nodejs#41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 16, 2021

mhdawson commented Dec 16, 2021

Copy link
Copy Markdown
Member Author

Identified as one of the top intermittent failures in recent reliability reports as part of our Red Hat team day to see what we could do to help move CI closer to green.

richardlau reviewed Dec 16, 2021
View reviewed changes
Comment thread test/parallel/parallel.status Outdated
# https://github.com/nodejs/node/issues/23277
test-worker-memory: PASS,FLAKY
# https://github.com/nodejs/node/issues/41206
test-crypto-keygen: SLOW

richardlau Dec 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Marking a test SLOW has no effect unless the test runner is run with --flaky-tests=skip which is not the case for Windows test builds (which run with --flaky-tests=dontcare but SLOW test are not FLAKY):

node/tools/test.py

Lines 1703 to 1704 in a257294

elif (options.flaky_tests == SKIP) and (set([SLOW, FLAKY]) & case.outcomes):
return False

See #23251 for when SLOW was introduced.

mhdawson Dec 16, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@richardlau thanks for pointing that out. Updated to mark as flaky instead.

mhdawson changed the title test: mark test-crypto-keygen slow on windows test: mark test-crypto-keygen flaky on windows Dec 16, 2021
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2021

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41207
✔  Done loading data for nodejs/node/pull/41207
----------------------------------- PR info ------------------------------------
Title      test: mark test-crypto-keygen flaky on windows (#41207)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:slow-windows -> nodejs:master
Labels     test, needs-ci
Commits    2
 - test: mark test-crypto-keygen slow on windows
 - Update parallel.status
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41207
Refs: https://github.com/nodejs/node/issues/41206
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41207
Refs: https://github.com/nodejs/node/issues/41206
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Dec 2021 20:20:55 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41207#pullrequestreview-834630872
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41207#pullrequestreview-835346669
   ✖  Last GitHub CI failed
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1598856323

nodejs-github-bot commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41557/

nodejs-github-bot commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41561/

github-actions Bot mentioned this pull request Dec 21, 2021
Open
22 tasks
mhdawson added a commit that referenced this pull request Dec 21, 2021
test: mark test-crypto-keygen slow on windows
eee1a6f 
Refs: #41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mhdawson commented Dec 21, 2021

Copy link
Copy Markdown
Member Author

Landed in eee1a6f

mhdawson closed this Dec 21, 2021
This was referenced Dec 22, 2021
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 14, 2022
test: mark test-crypto-keygen slow on windows
367ab2a 
Refs: #41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
test: mark test-crypto-keygen slow on windows
9da2224 
Refs: #41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
test: mark test-crypto-keygen slow on windows
2e133d5 
Refs: #41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL